Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2726)

Unified Diff: content/renderer/origin_trials/trial_token.h

Issue 1742053002: Move trial token code to content/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/origin_trials/trial_token.h
diff --git a/content/renderer/origin_trials/trial_token.h b/content/renderer/origin_trials/trial_token.h
deleted file mode 100644
index 216c9b97ad94f2176b32f2d6b8ea39f7507080b0..0000000000000000000000000000000000000000
--- a/content/renderer/origin_trials/trial_token.h
+++ /dev/null
@@ -1,109 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CONTENT_RENDERER_ORIGIN_TRIALS_TRIAL_TOKEN_H_
-#define CONTENT_RENDERER_ORIGIN_TRIALS_TRIAL_TOKEN_H_
-
-#include <string>
-
-#include "base/memory/scoped_ptr.h"
-#include "base/strings/string_piece.h"
-#include "base/time/time.h"
-#include "content/common/content_export.h"
-#include "url/origin.h"
-
-namespace content {
-
-// The Experimental Framework (EF) provides limited access to experimental
-// features, on a per-origin basis (origin trials). This class defines the trial
-// token data structure, used to securely provide access to an experimental
-// feature.
-//
-// Features are defined by string names, provided by the implementers. The EF
-// code does not maintain an enum or constant list for feature names. Instead,
-// the EF validates the name provided by the feature implementation against any
-// provided tokens.
-//
-// More documentation on the token format can be found at
-// https://docs.google.com/document/d/1v5fi0EUV_QHckVHVF2K4P72iNywnrJtNhNZ6i2NPt0M
-
-class CONTENT_EXPORT TrialToken {
- public:
- ~TrialToken();
-
- // Returns a token object if the string represents a well-formed token, or
- // nullptr otherwise. (This does not mean that the token is valid, just that
- // it can be parsed.)
- static scoped_ptr<TrialToken> Parse(const std::string& token_text);
-
- // Returns true if this feature is appropriate for use by the given origin,
- // for the given feature name. This does not check whether the signature is
- // valid, or whether the token itself has expired.
- bool IsAppropriate(const url::Origin& origin,
- base::StringPiece feature_name) const;
-
- // Returns true if this token has a valid signature, and has not expired.
- bool IsValid(const base::Time& now, base::StringPiece public_key) const;
-
- uint8_t version() { return version_; }
- std::string signature() { return signature_; }
- std::string data() { return data_; }
- url::Origin origin() { return origin_; }
- std::string feature_name() { return feature_name_; }
- base::Time expiry_time() { return expiry_time_; }
-
- protected:
- friend class TrialTokenTest;
-
- bool ValidateOrigin(const url::Origin& origin) const;
- bool ValidateFeatureName(base::StringPiece feature_name) const;
- bool ValidateDate(const base::Time& now) const;
- bool ValidateSignature(base::StringPiece public_key) const;
-
- static bool ValidateSignature(const std::string& signature_text,
- const std::string& data,
- base::StringPiece public_key);
-
- private:
- TrialToken(uint8_t version,
- const std::string& signature,
- const std::string& data,
- const url::Origin& origin,
- const std::string& feature_name,
- uint64_t expiry_timestamp);
-
- // The version number for this token. The version identifies the structure of
- // the token, as well as the algorithm used to generate/validate the token.
- // The version number is only incremented when incompatible changes are made
- // to either the structure (e.g. adding a field), or the algorithm (e.g.
- // changing the hash or signing algorithm).
- // NOTE: The version number is not part of the token signature and validation.
- // Thus it is possible to modify a token to use a different version from
- // that used to generate the signature. To mitigate cross-version
- // attacks, the signing key(s) should be changed whenever there are
- // changes to the token structure or algorithms.
- uint8_t version_;
-
- // The base64-encoded-signature portion of the token. For the token to be
- // valid, this must be a valid signature for the data portion of the token, as
- // verified by the public key in trial_token.cc.
- std::string signature_;
-
- // The portion of the token string which is signed, and whose signature is
- // contained in the signature_ member.
- std::string data_;
-
- // The origin for which this token is valid. Must be a secure origin.
- url::Origin origin_;
-
- // The name of the experimental feature which this token enables.
- std::string feature_name_;
-
- // The time until which this token should be considered valid.
- base::Time expiry_time_;
-};
-
-} // namespace content
-
-#endif // CONTENT_RENDERER_ORIGIN_TRIALS_TRIAL_TOKEN_H_

Powered by Google App Engine
This is Rietveld 408576698