chrome/common/origin_trials/origin_trial_key_manager.h - Issue 1742053002: Move trial token code to content/common.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/origin_trials/origin_trial_key_manager.h

Issue 1742053002: Move trial token code to content/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

	6 #define CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

	7

	8 #include "base/strings/string_piece.h"

	9

	10 // This class is instantiated on the main/ui thread, but its methods can be

	11 // accessed from any thread.

	12 class OriginTrialKeyManager {
	Nico 2016/03/11 21:49:05 (why is this an instantiated class instead of just (why is this an instantiated class instead of just a function?) Marijn Kruisselbrink 2016/03/11 21:56:36 I'm not sure. I think iclelland@ had some future p Show quoted text On 2016/03/11 at 21:49:05, Nico wrote: > (why is this an instantiated class instead of just a function?) I'm not sure. I think iclelland@ had some future plans to do things like caching signature verification results, if that turned out to be a bottleneck, so I assume this is instantiated to be able to store that state.
	13 public:

	14 base::StringPiece GetPublicKey();

	15 };

	16

	17 #endif // CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

OLD	NEW