Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1742013002: [cleanup] Move ForEach vector feedback slots to ForInStatement (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Move ForEach vector feedback slots to ForInStatement The "each" slot is only actually used by ForIn, so this simply cleans up a TODO of mine and removes an IsForOfStatement() call. Committed: https://crrev.com/65b23ac721b5f0b162eaa2e327c77108d14dc261 Cr-Commit-Position: refs/heads/master@{#34369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M src/ast/ast.h View 4 chunks +3 lines, -10 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 9 months ago (2016-02-27 00:20:03 UTC) #2
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-02-29 17:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1742013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1742013002/1
4 years, 9 months ago (2016-02-29 18:39:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 19:09:16 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 19:10:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65b23ac721b5f0b162eaa2e327c77108d14dc261
Cr-Commit-Position: refs/heads/master@{#34369}

Powered by Google App Engine
This is Rietveld 408576698