Move the following clipboard files from webkit\glue to webkit\renderer. These files now live in the…

Move the following clipboard files from webkit\glue to content\renderer. These files now live in the content_renderer target.

1. scoped_clipboard_writer_glue.h
2. scoped_clipboard_writer_glue.cc
3. webclipboard_impl.cc
4. webclipboard_impl.h
5. clipboard_client.h

I moved the static functions URLToMarkup and URLToImageMarkup out of the WebClipboardImpl class to the
newly added webkit\renderer\clipboard_utils.cc/.h files as these functions are used by the MockWebClipboardImpl class
which lives in webkit\support. This class is eventually used by the webkit_unit_tests target. Moving these functions out
avoids the dependency on content in webkit_unit_tests.

This is continuation of the ongoing work for bug https://code.google.com/p/chromium/issues/detail?can=2&q=237249
which is splitting chrome.dll into a browser and renderer component due to build issues on Windows.

BUG=237249
R=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207657

[jamesr, 2013-06-19 18:10:32]

This looks good, but can we move these straight into content/renderer ?

[ananta, 2013-06-19 19:43:48]

On 2013/06/19 18:10:32, jamesr wrote:
> This looks good, but can we move these straight into content/renderer ?

Done. To get that to work I moved the URLToMarkup and URLToImageMarkup functions
out of the WebClipboardImpl class to the
newly added webkit\renderer\clipboard_utils.cc/.h. This prevents
webkit_unit_tests from depending on content.

PTAL

[jamesr, 2013-06-19 19:49:20]

lgtm. i think we can get rid of some of the interfaces, but that doesn't have to
happen at the same time as the move

https://codereview.chromium.org/17420005/diff/67001/content/renderer/clipboar...
File content/renderer/clipboard_client.h (right):

https://codereview.chromium.org/17420005/diff/67001/content/renderer/clipboar...
content/renderer/clipboard_client.h:5: #ifndef WEBKIT_GLUE_CLIPBOARD_CLIENT_H_
update include guard

(tools/git/mass_rename.sh / move_source_file.py will update these for you if
you're using git)

https://codereview.chromium.org/17420005/diff/67001/content/renderer/clipboar...
content/renderer/clipboard_client.h:14: // Interface for the webkit glue
embedder to implement to support clipboard.
can you update this comment? actually, do we even need this interface any more?
are there any implementations other than RendererClipboardClient?

https://codereview.chromium.org/17420005/diff/67001/content/renderer/renderer...
File content/renderer/renderer_clipboard_client.cc (right):

https://codereview.chromium.org/17420005/diff/67001/content/renderer/renderer...
content/renderer/renderer_clipboard_client.cc:5: // This file provides the
embedder's side of random webkit glue functions.
please update

[ananta, 2013-06-19 19:56:14]

https://codereview.chromium.org/17420005/diff/67001/content/renderer/clipboar...
File content/renderer/clipboard_client.h (right):

https://codereview.chromium.org/17420005/diff/67001/content/renderer/clipboar...
content/renderer/clipboard_client.h:5: #ifndef WEBKIT_GLUE_CLIPBOARD_CLIENT_H_
On 2013/06/19 19:49:20, jamesr wrote:
> update include guard
> 
> (tools/git/mass_rename.sh / move_source_file.py will update these for you if
> you're using git)

Done.

https://codereview.chromium.org/17420005/diff/67001/content/renderer/clipboar...
content/renderer/clipboard_client.h:14: // Interface for the webkit glue
embedder to implement to support clipboard.
On 2013/06/19 19:49:20, jamesr wrote:
> can you update this comment? actually, do we even need this interface any
more?
> are there any implementations other than RendererClipboardClient?
Done. SimpleClipboardClient implemented this interface and is going away in this
CL. WebClipboardImpl takes in this interface as a pointer in its ctor. I will
take a look into removing this interface in a subsequent change.

https://codereview.chromium.org/17420005/diff/67001/content/renderer/renderer...
File content/renderer/renderer_clipboard_client.cc (right):

https://codereview.chromium.org/17420005/diff/67001/content/renderer/renderer...
content/renderer/renderer_clipboard_client.cc:5: // This file provides the
embedder's side of random webkit glue functions.
On 2013/06/19 19:49:20, jamesr wrote:
> please update

Done.

[ananta, 2013-06-21 00:40:31]

Committed patchset #14 manually as r207657 (presubmit successful).