Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1741973002: Add gamma_correct option field to dm.json (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
egdaniel, stephana, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add gamma_correct option field to dm.json E.g. { "max_rss_MB" : 23, "results" : [ { "key" : { "config" : "pdf", "name" : "gamma", "source_type" : "gm" }, "md5" : "c5dfb531f4d76c77c3305b6a04733262", "options" : { "ext" : "pdf", "gamma_correct" : false } }, { "key" : { "config" : "8888", "name" : "gamma", "source_type" : "gm" }, "md5" : "6177860ed24106446d3a9087527e67bf", "options" : { "ext" : "png", "gamma_correct" : false } }, { "key" : { "config" : "f16", "name" : "gamma", "source_type" : "gm" }, "md5" : "213f80145953ecd4c71e0612447b2ad9", "options" : { "ext" : "png", "gamma_correct" : true } } ] } BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1741973002 Committed: https://skia.googlesource.com/skia/+/409d470a4973e2ba9f95983b9820931adcf7cd73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M dm/DM.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M dm/DMJsonWriter.h View 1 chunk +1 line, -0 lines 0 comments Download
M dm/DMJsonWriter.cpp View 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mtklein_C
4 years, 10 months ago (2016-02-26 23:34:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741973002/1
4 years, 10 months ago (2016-02-26 23:34:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 23:50:45 UTC) #8
egdaniel
this lgtm, may what stephan to confirm this is what he wants to see in ...
4 years, 10 months ago (2016-02-26 23:56:46 UTC) #9
stephana
On 2016/02/26 23:56:46, egdaniel wrote: > this lgtm, may what stephan to confirm this is ...
4 years, 9 months ago (2016-02-29 15:13:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741973002/1
4 years, 9 months ago (2016-02-29 15:22:00 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 15:38:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/409d470a4973e2ba9f95983b9820931adcf7cd73

Powered by Google App Engine
This is Rietveld 408576698