Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: mojo/services/files/interfaces/file.mojom

Issue 1741963002: Auto-formatted all .mojom files. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/files/interfaces/file.mojom
diff --git a/mojo/services/files/interfaces/file.mojom b/mojo/services/files/interfaces/file.mojom
index c2f2bdd9df3afa367f1b47a03d7ba0a0fa379217..15aa38f2106a85bd6a4514742653955d72618f3b 100644
--- a/mojo/services/files/interfaces/file.mojom
+++ b/mojo/services/files/interfaces/file.mojom
@@ -25,26 +25,20 @@ interface File {
// are read.
// TODO(vtl): Clarify when (for what values of |offset|/|whence|) this
// modifies the file position. Or maybe there should be a flag?
- Read(uint32 num_bytes_to_read, int64 offset, Whence whence)
- => (Error error, array<uint8>? bytes_read);
+ Read(uint32 num_bytes_to_read, int64 offset, Whence whence) => (Error error, array<uint8>? bytes_read);
// Writes |bytes_to_write| to the location specified by |offset|/|whence|.
// TODO(vtl): Clarify behavior when |num_bytes_written| is less than the size
// of |bytes_to_write|.
- Write(array<uint8> bytes_to_write, int64 offset, Whence whence)
- => (Error error, uint32 num_bytes_written);
+ Write(array<uint8> bytes_to_write, int64 offset, Whence whence) => (Error error, uint32 num_bytes_written);
// TODO(vtl): We definitely want 64 bits for |num_bytes_to_read|; but do we
// want it to be signed (this is consistent with |size| values, but
// inconsistent with 32-bit |num_bytes_to_read| values)? Do we want to have
// separate "read to end" versus "tail" (i.e., keep on reading as more data is
// appended) modes, and how would those be signaled?
- ReadToStream(handle<data_pipe_producer> source,
- int64 offset,
- Whence whence,
- int64 num_bytes_to_read) => (Error error);
- WriteFromStream(handle<data_pipe_consumer> sink, int64 offset, Whence whence)
- => (Error error);
+ ReadToStream(handle<data_pipe_producer> source, int64 offset, Whence whence, int64 num_bytes_to_read) => (Error error);
+ WriteFromStream(handle<data_pipe_consumer> sink, int64 offset, Whence whence) => (Error error);
// Gets the current file position. On success, |position| is the current
// offset (in bytes) from the beginning of the file).
@@ -84,8 +78,7 @@ interface File {
// Special-file-specific control function, for device "files". |in| and |out|
// are dependent on |request|. See ioctl.mojom for the master list of request
// values.
- Ioctl(uint32 request, array<uint32>? in_values)
- => (Error error, array<uint32>? out_values);
+ Ioctl(uint32 request, array<uint32>? in_values) => (Error error, array<uint32>? out_values);
// TODO(vtl): Add a "watch"?
// TODO(vtl): Add something analogous to fsync(2)?

Powered by Google App Engine
This is Rietveld 408576698