Chromium Code Reviews| Index: mojo/public/interfaces/bindings/tests/sample_service.mojom |
| diff --git a/mojo/public/interfaces/bindings/tests/sample_service.mojom b/mojo/public/interfaces/bindings/tests/sample_service.mojom |
| index 1fa303b8dda7c9eb17cb28f4874acdddce2f0d6c..6a22e9f974a667f2b8ff4c1f3cc0cbf49bfc0f36 100644 |
| --- a/mojo/public/interfaces/bindings/tests/sample_service.mojom |
| +++ b/mojo/public/interfaces/bindings/tests/sample_service.mojom |
| @@ -2,7 +2,8 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -[DartPackage="_mojo_for_test_only", JavaPackage="org.chromium.mojo.bindings.test.mojom.sample"] |
| +[DartPackage="_mojo_for_test_only", |
| +JavaPackage="org.chromium.mojo.bindings.test.mojom.sample"] |
| module sample; |
| import "sample_import.mojom"; |
| @@ -15,7 +16,7 @@ struct Bar { |
| VERTICAL = 1, |
| HORIZONTAL, |
| BOTH, |
| - INVALID |
| + INVALID, |
| }; |
| uint8 alpha@0 = 0xff; |
| uint8 beta@1; |
| @@ -53,14 +54,14 @@ struct DefaultsTest { |
| uint64 a7@7 = 9999999999999999999; |
| int32 a8@8 = 0x12345; |
| int32 a9@9 = -0x12345; |
| - int32 a10@10 = +1234; |
| + int32 a10@10 = 1234; |
|
jamesr
2016/02/29 23:40:49
i think the "+" was deliberate - any reason the fo
vtl
2016/02/29 23:41:59
I don't know that you should forcibly drop the "+"
azani
2016/03/04 01:08:49
That information is tossed by the parser. We could
|
| bool a11@11 = true; |
| bool a12@12 = false; |
| float a13@13 = 123.25; |
| double a14@14 = 1234567890.123; |
| double a15@15 = 1E10; |
| double a16@16 = -1.2E+20; |
| - double a17@17 = +1.23E-20; |
| + double a17@17 = 1.23E-20; |
|
vtl
2016/02/29 23:41:59
"
|
| // TODO(vtl): Add tests for default vs null when those are implemented (for |
| // structs, arrays, and strings). |
| @@ -97,11 +98,11 @@ struct StructWithHoleV2 { |
| interface Service { |
| enum BazOptions { |
| REGULAR = 0, |
| - EXTRA |
| + EXTRA, |
| }; |
| const uint8 kFavoriteBaz = 1; |
| Frobinate@0(Foo? foo@0, BazOptions baz@1, Port? port@2) => (int32 result@0); |
| - GetPort@1(Port& port @0); |
| + GetPort@1(Port& port@0); |
| }; |
| // This interface is referenced above where it is defined. It also refers to |