Re-apply r23841 "During uninstall if Chrome is set as default"

chrome/browser/browser_main_win.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_main_win.h"
 
 #include <windows.h>
 #include <shellapi.h>
 
 #include "app/l10n_util.h"
 #include "app/message_box_flags.h"
 #include "app/win_util.h"
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/win_util.h"
 #include "chrome/browser/first_run.h"
 #include "chrome/browser/metrics/metrics_service.h"
-#include "chrome/browser/views/uninstall_dialog.h"
+#include "chrome/browser/views/uninstall_view.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/env_vars.h"
 #include "chrome/common/result_codes.h"
 #include "chrome/installer/util/helper.h"
 #include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/shell_util.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
-#include "views/controls/message_box_view.h"
 #include "views/focus/accelerator_handler.h"
 #include "views/window/window.h"
 
 // Displays a warning message if the user is running chrome on windows 2000.
 // Returns true if the OS is win2000, false otherwise.
 bool CheckForWin2000() {
   if (win_util::GetWinVersion() == win_util::WINVERSION_2000) {
     const std::wstring text = l10n_util::GetString(IDS_UNSUPPORTED_OS_WIN2000);
     const std::wstring caption = l10n_util::GetString(IDS_PRODUCT_NAME);
     win_util::MessageBox(NULL, text, caption,
                          MB_OK | MB_ICONWARNING | MB_TOPMOST);
     return true;
   }
   return false;
 }
 
 int AskForUninstallConfirmation() {
   int ret = ResultCodes::NORMAL_EXIT;
-  UninstallDialog::ShowUninstallDialog(ret);
+  views::Window::CreateChromeWindow(NULL, gfx::Rect(),
+                                    new UninstallView(ret))->Show();
   views::AcceleratorHandler accelerator_handler;
   MessageLoopForUI::current()->Run(&accelerator_handler);
   return ret;
 }
 
 void ShowCloseBrowserFirstMessageBox() {
   const std::wstring text = l10n_util::GetString(IDS_UNINSTALL_CLOSE_APP);
   const std::wstring caption = l10n_util::GetString(IDS_PRODUCT_NAME);
   const UINT flags = MB_OK | MB_ICONWARNING | MB_TOPMOST;
   win_util::MessageBox(NULL, text, caption, flags);
 }
 
 int DoUninstallTasks(bool chrome_still_running) {
+  // We want to show a warning to user (and exit) if Chrome is already running
+  // *before* we show the uninstall confirmation dialog box. But while the
+  // uninstall confirmation dialog is up, user might start Chrome, so we
+  // check once again after user acknowledges Uninstall dialog.
   if (chrome_still_running) {
     ShowCloseBrowserFirstMessageBox();
     return ResultCodes::UNINSTALL_CHROME_ALIVE;
   }
   int ret = AskForUninstallConfirmation();
+  if (Upgrade::IsBrowserAlreadyRunning()) {
+    ShowCloseBrowserFirstMessageBox();
+    return ResultCodes::UNINSTALL_CHROME_ALIVE;
+  }
+
   if (ret != ResultCodes::UNINSTALL_USER_CANCEL) {
     // The following actions are just best effort.
     LOG(INFO) << "Executing uninstall actions";
     if (!FirstRun::RemoveSentinel())
       LOG(INFO) << "Failed to delete sentinel file.";
     // We want to remove user level shortcuts and we only care about the ones
     // created by us and not by the installer so |alternate| is false.
     if (!ShellUtil::RemoveChromeDesktopShortcut(ShellUtil::CURRENT_USER, false))
       LOG(INFO) << "Failed to delete desktop shortcut.";
     if (!ShellUtil::RemoveChromeQuickLaunchShortcut(ShellUtil::CURRENT_USER))
@@ skipping 110 matching lines @@
 }
 
 // We record in UMA the conditions that can prevent breakpad from generating
 // and sending crash reports. Namely that the crash reporting registration
 // failed and that the process is being debugged.
 void RecordBreakpadStatusUMA(MetricsService* metrics) {
   DWORD len = ::GetEnvironmentVariableW(env_vars::kNoOOBreakpad, NULL, 0);
   metrics->RecordBreakpadRegistration((len == 0));
   metrics->RecordBreakpadHasDebugger(TRUE == ::IsDebuggerPresent());
 }