Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1741903002: Fix strict mode function error message (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix strict mode function error message ES2015 allows strict mode block scoped function declarations; weaken the error message about misuse to allow this. BUG=v8:2198 LOG=Y R=adamk Committed: https://crrev.com/92ed0853b9ec677c8da8c9938e6616818c2a0ab9 Cr-Commit-Position: refs/heads/master@{#34339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Dan Ehrenberg
4 years, 9 months ago (2016-02-26 19:50:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741903002/1
4 years, 9 months ago (2016-02-26 19:50:40 UTC) #3
Dan Ehrenberg
4 years, 9 months ago (2016-02-26 19:50:41 UTC) #4
adamk
lgtm
4 years, 9 months ago (2016-02-26 19:51:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741903002/1
4 years, 9 months ago (2016-02-26 19:55:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-26 20:12:39 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 20:12:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92ed0853b9ec677c8da8c9938e6616818c2a0ab9
Cr-Commit-Position: refs/heads/master@{#34339}

Powered by Google App Engine
This is Rietveld 408576698