[HTML Imports] Implement sub-imports processing.

[HTML Imports] Implement sub-imports processing.

s change introduces sub-imports processing.
Before this change, a placeholder document for imported document is
plain frame-less document and it didn't load any external resources.

This change lets imported documents share HTMLImportsController with the master document,
so that the document can do (sub)-import processing using the shared controller.

Each <link> in a document sees if the owner document has an import controller,
and starts loading import if there is the controller available.

BUG=240592
TEST=import-master.html, no-browsing-context.html, sub-imports.html, sub-imports-loop.html
R=dglazkov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152755

[Hajime Morrita, 2013-06-19 07:01:24]

Sub-imports patch is back, this time with imported document!

[dglazkov, 2013-06-19 16:13:01]

https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
File Source/core/html/HTMLImportsController.cpp (right):

https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
Source/core/html/HTMLImportsController.cpp:74: if (!m_owner->document()->frame()
&& !m_owner->document()->imports())
This is odd. You're checking for imports() existence and only later calling
ensureImports(). How does this work?

https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
Source/core/html/HTMLImportsController.cpp:81: HTMLImportsController* controller
= m_owner->document()->ensureImports();
It seems like we should be just using setImport here instead of using RAII
pattern, right?

[Hajime Morrita, 2013-06-19 22:04:29]

Hi Dimitri, thanks for the review! Comments inline.

https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
File Source/core/html/HTMLImportsController.cpp (right):

https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
Source/core/html/HTMLImportsController.cpp:74: if (!m_owner->document()->frame()
&& !m_owner->document()->imports())
We proceed even when there are frame() but !import().
This is master document case in which ensureImport() actually creates import.
if !frame() and import(), it's a sub-import case.

https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
Source/core/html/HTMLImportsController.cpp:81: HTMLImportsController* controller
= m_owner->document()->ensureImports();
On 2013/06/19 16:13:01, Dimitri Glazkov wrote:
> It seems like we should be just using setImport here instead of using RAII
> pattern, right?
I'm sorry but I don:t quite get the point? Could you elaborate which RAII you
talking about?

[dglazkov, 2013-06-19 22:14:15]

https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
File Source/core/html/HTMLImportsController.cpp (right):

https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
Source/core/html/HTMLImportsController.cpp:81: HTMLImportsController* controller
= m_owner->document()->ensureImports();
On 2013/06/19 22:04:29, morrita1 wrote:
> On 2013/06/19 16:13:01, Dimitri Glazkov wrote:
> > It seems like we should be just using setImport here instead of using RAII
> > pattern, right?
> I'm sorry but I don:t quite get the point? Could you elaborate which RAII you
> talking about?

Yes! instead of using ensureImport(), just use setImport here. This way, the
distinction between master and sub-import is clearly captured here in the code.

[Hajime Morrita, 2013-06-19 22:23:48]

On 2013/06/19 22:14:15, Dimitri Glazkov wrote:
>
https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
> File Source/core/html/HTMLImportsController.cpp (right):
> 
>
https://codereview.chromium.org/17419007/diff/1/Source/core/html/HTMLImportsC...
> Source/core/html/HTMLImportsController.cpp:81: HTMLImportsController*
controller
> = m_owner->document()->ensureImports();
> On 2013/06/19 22:04:29, morrita1 wrote:
> > On 2013/06/19 16:13:01, Dimitri Glazkov wrote:
> > > It seems like we should be just using setImport here instead of using RAII
> > > pattern, right?
> > I'm sorry but I don:t quite get the point? Could you elaborate which RAII
you
> > talking about?
> 
> Yes! instead of using ensureImport(), just use setImport here. This way, the
> distinction between master and sub-import is clearly captured here in the
code.
Ah, got the point! will do.

[Hajime Morrita, 2013-06-20 01:17:35]

ptal?

[dglazkov, 2013-06-20 01:27:55]

complains about chunk mismatch :-\

[dglazkov, 2013-06-20 01:28:56]

LGTM! I looked at raw patch :)

[Hajime Morrita, 2013-06-20 01:30:58]

Oops. Should rebase before land. thanks!

[commit-bot: I haz the power, 2013-06-20 01:47:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/morrita@chromium.org/17419007/16001

[Hajime Morrita, 2013-06-20 06:23:33]

Committed patchset #3 manually as r152755 (presubmit successful).