Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2363)

Unified Diff: extensions/common/event_filtering_info.cc

Issue 17419004: <webview>: Add support for filtering extension events by instanceId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filter_listener
Patch Set: Correct diff Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/event_filtering_info.cc
diff --git a/extensions/common/event_filtering_info.cc b/extensions/common/event_filtering_info.cc
index 009dcaa46fbce030616b584559a1d4b2890021ea..808835f60d24ddbe2363548a1b2d9feb2da6d0cf 100644
--- a/extensions/common/event_filtering_info.cc
+++ b/extensions/common/event_filtering_info.cc
@@ -10,7 +10,9 @@
namespace extensions {
EventFilteringInfo::EventFilteringInfo()
- : has_url_(false) {
+ : has_url_(false),
+ has_instance_id_(false),
+ instance_id_(0) {
}
EventFilteringInfo::~EventFilteringInfo() {
@@ -21,12 +23,20 @@ void EventFilteringInfo::SetURL(const GURL& url) {
has_url_ = true;
}
+void EventFilteringInfo::SetInstanceID(int instance_id) {
+ instance_id_ = instance_id;
+ has_instance_id_ = true;
+}
+
std::string EventFilteringInfo::AsJSONString() const {
std::string result;
base::DictionaryValue value;
if (has_url_)
value.SetString("url", url_.spec());
+ if (has_instance_id_)
+ value.SetInteger("instanceId", instance_id_);
+
base::JSONWriter::Write(&value, &result);
return result;
}
@@ -38,6 +48,9 @@ scoped_ptr<base::Value> EventFilteringInfo::AsValue() const {
scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue);
if (has_url_)
result->SetString("url", url_.spec());
+
+ if (has_instance_id_)
+ result->SetInteger("instanceId", instance_id_);
return result.PassAs<base::Value>();
}

Powered by Google App Engine
This is Rietveld 408576698