Issue 17419004: <webview>: Add support for filtering extension events by instanceId.

Issue 17419004: <webview>: Add support for filtering extension events by instanceId. (Closed)

Created:
7 years, 6 months ago by Fady Samuel

Modified:
7 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@filter_listener

Visibility:
Public.

More Reviews

Description

<webview>: Add support for filtering extension events by instanceId. BUG=166165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207213

Patch Set 3 : Updated #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -12 lines)			Patch
M	chrome/renderer/extensions/event_bindings.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	extensions/common/event_filtering_info.h	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
M	extensions/common/event_filtering_info.cc	View	1 2	3 chunks	+9 lines, -9 lines	0 comments	Download
M	extensions/common/event_matcher.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	extensions/common/event_matcher.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Fady Samuel

Hi Matt, This adds support for filtering extension events by instance ID for <webview> as ...

7 years, 6 months ago (2013-06-18 20:44:28 UTC) #1

Matt Perry

Yes, this looks right. LGTM https://codereview.chromium.org/17419004/diff/2001/extensions/common/event_filtering_info.h File extensions/common/event_filtering_info.h (right): https://codereview.chromium.org/17419004/diff/2001/extensions/common/event_filtering_info.h#newcode38 extensions/common/event_filtering_info.h:38: std::string AsJSONString() const; This ...

7 years, 6 months ago (2013-06-18 23:29:02 UTC) #2

Fady Samuel

https://codereview.chromium.org/17419004/diff/2001/extensions/common/event_filtering_info.h File extensions/common/event_filtering_info.h (right): https://codereview.chromium.org/17419004/diff/2001/extensions/common/event_filtering_info.h#newcode38 extensions/common/event_filtering_info.h:38: std::string AsJSONString() const; On 2013/06/18 23:29:02, Matt Perry wrote: ...

7 years, 6 months ago (2013-06-19 01:15:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/17419004/7001

7 years, 6 months ago (2013-06-19 01:15:41 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=127407

7 years, 6 months ago (2013-06-19 10:40:46 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/17419004/7001

7 years, 6 months ago (2013-06-19 11:34:17 UTC) #6

Message was sent while issue was closed.

Change committed as 207213

Expand Messages | Collapse Messages