Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1741873002:
Fix isEqualNode behavior (Closed)
|
Created:
4 years, 10 months ago by rwlbuis Modified:
4 years, 9 months ago Reviewers:
tkent CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, sof Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix isEqualNode behavior
According to the steps listed in [1] isEqualNode should use
namespace, namespace prefix and local name when comparing
Elements, so we can just use tagQName. Note that nodeName
differs from localName since it uppercases the tag name
for HTML.
This patch fixes dom/nodes/Node-isEqualNode.html.
[1] https://dom.spec.whatwg.org/#dom-node-isequalnode
BUG=590269
Committed: https://crrev.com/e9abd40342698947a867e3f690783f6eea093ab4
Cr-Commit-Position: refs/heads/master@{#378202}
Patch Set 1 #Patch Set 2 : V2 #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== isEqualNode WIP BUG= ========== to ========== isEqualNode WIP BUG=590269 ==========
Description was changed from ========== isEqualNode WIP BUG=590269 ========== to ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use localName on Elements. This patch does that and fixes: http://w3c-test.org/dom/nodes/Node-isEqualNode.html [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ==========
Description was changed from ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use localName on Elements. This patch does that and fixes: http://w3c-test.org/dom/nodes/Node-isEqualNode.html [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ========== to ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use localName (not nodeName) on Elements. This patch does that and fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ==========
Description was changed from ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use localName (not nodeName) on Elements. This patch does that and fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ========== to ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use localName (not nodeName) when comparing Elements. This patch does that and fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ==========
rob.buis@samsung.com changed reviewers: + tkent@chromium.org
PTAL.
lgtm. We can improve the CL description. > According to the steps listed in [1] isEqualNode should use > localName (not nodeName) when comparing Elements. - Also, the specification says namespace prefixes should be compared. So, comparing tagQName is reasonable. - Explaining difference between nodeName() and localName() would be helpful.
Description was changed from ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use localName (not nodeName) when comparing Elements. This patch does that and fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ========== to ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use namespace, namespace prefix and local name when comparing Elements, so we can just use tagQName. Note that nodeName is different than localName since it uppercases the tag name for HTML. This patch fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ==========
Description was changed from ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use namespace, namespace prefix and local name when comparing Elements, so we can just use tagQName. Note that nodeName is different than localName since it uppercases the tag name for HTML. This patch fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ========== to ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use namespace, namespace prefix and local name when comparing Elements, so we can just use tagQName. Note that nodeName differs from localName since it uppercases the tag name for HTML. This patch fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ==========
On 2016/02/29 00:43:50, tkent wrote: > lgtm. Thanks! > We can improve the CL description. > > > According to the steps listed in [1] isEqualNode should use > > localName (not nodeName) when comparing Elements. > > - Also, the specification says namespace prefixes should be compared. > So, comparing tagQName is reasonable. > > - Explaining difference between nodeName() and localName() would be helpful. Done :)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741873002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741873002/20001
Message was sent while issue was closed.
Description was changed from ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use namespace, namespace prefix and local name when comparing Elements, so we can just use tagQName. Note that nodeName differs from localName since it uppercases the tag name for HTML. This patch fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ========== to ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use namespace, namespace prefix and local name when comparing Elements, so we can just use tagQName. Note that nodeName differs from localName since it uppercases the tag name for HTML. This patch fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use namespace, namespace prefix and local name when comparing Elements, so we can just use tagQName. Note that nodeName differs from localName since it uppercases the tag name for HTML. This patch fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 ========== to ========== Fix isEqualNode behavior According to the steps listed in [1] isEqualNode should use namespace, namespace prefix and local name when comparing Elements, so we can just use tagQName. Note that nodeName differs from localName since it uppercases the tag name for HTML. This patch fixes dom/nodes/Node-isEqualNode.html. [1] https://dom.spec.whatwg.org/#dom-node-isequalnode BUG=590269 Committed: https://crrev.com/e9abd40342698947a867e3f690783f6eea093ab4 Cr-Commit-Position: refs/heads/master@{#378202} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e9abd40342698947a867e3f690783f6eea093ab4 Cr-Commit-Position: refs/heads/master@{#378202} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
