Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1741833002: Reduce ephemeron stack size reservation. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce ephemeron stack size reservation. The ephemeron stack is used by the Oilpan GC to handle key-value pairs over weak references as wanted (i.e., the value is strongly referenced until the key becomes unreachable). The marking process will push hash tables containing such onto a stack processing for later processing. Blink only has a handful of hash tables requiring ephemeron processing, hence tune down the initial size of the stack accordingly. As a data point, browsing around on various popular sites resulted in ephemeron stacks no deeper than in the mid-20s. R=haraken BUG= Committed: https://crrev.com/ac2a059d4486172d24bdcf5b82be6f5300d5102d Cr-Commit-Position: refs/heads/master@{#378131}

Patch Set 1 #

Patch Set 2 : round up #

Patch Set 3 : const-ify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/CallbackStack.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/CallbackStack.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
sof
please take a look. one page blocks for this stack should be more than enough ...
4 years, 9 months ago (2016-02-26 18:39:20 UTC) #3
haraken
LGTM
4 years, 9 months ago (2016-02-27 03:17:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741833002/40001
4 years, 9 months ago (2016-02-27 06:02:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/28592) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-02-27 06:14:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741833002/40001
4 years, 9 months ago (2016-02-27 07:50:54 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-02-27 08:57:15 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-02-27 08:58:42 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ac2a059d4486172d24bdcf5b82be6f5300d5102d
Cr-Commit-Position: refs/heads/master@{#378131}

Powered by Google App Engine
This is Rietveld 408576698