Cast:Transport: Dividing A/V Initialization pipeline

media/cast/transport/cast_transport_defines.h

Index: media/cast/transport/cast_transport_defines.h
diff --git a/media/cast/transport/cast_transport_defines.h b/media/cast/transport/cast_transport_defines.h
index 7d8f76617941392606530fd0fb835613c171a112..72089fc74902f91490c66809d7d29ae7be3c5e60 100644
--- a/media/cast/transport/cast_transport_defines.h
+++ b/media/cast/transport/cast_transport_defines.h
@@ -18,8 +18,10 @@ namespace transport {
 
 // TODO(mikhal): Implement and add more types.
 enum CastTransportStatus {
-  TRANSPORT_UNINITIALIZED = 0,
-  TRANSPORT_INITIALIZED,
+  TRANSPORT_AUDIO_UNINITIALIZED = 0,

[hubbe, 2014/02/21 23:41:23]

These transport statuses makes no sense.
If I call InitVideo and then InitAudio, but there is an error in the video
config, what will the status be?
Maybe add some comments for how to interpret these things?

[mikhal1, 2014/02/24 17:02:50]

Each initialization should trigger the callback with the relevant status. I
divided it to allow the application to distinguish between audio and video
(assuming they are using the callback for both).
Added a comment in cast_transport_sender.h
On 2014/02/21 23:41:23, hubbe wrote:

[hubbe, 2014/02/25 00:37:04]

In that case, let's change the status callback to take two parameters, one which
specifies audio/video/other, and one which indicates the status.

[mikhal1, 2014/02/25 18:07:02]

I'm not sure that's much better, as there's only one transport.

+  TRANSPORT_VIDEO_UNINITIALIZED,
+  TRANSPORT_AUDIO_INITIALIZED,
+  TRANSPORT_VIDEO_INITIALIZED,
   TRANSPORT_INVALID_CRYPTO_CONFIG,
   TRANSPORT_SOCKET_ERROR,
   CAST_TRANSPORT_STATUS_LAST = TRANSPORT_SOCKET_ERROR