Cast:Transport: Dividing A/V Initialization pipeline

chrome/renderer/media/cast_session_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_MEDIA_CAST_SESSION_DELEGATE_H_
 #define CHROME_RENDERER_MEDIA_CAST_SESSION_DELEGATE_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
 #include "base/threading/thread.h"
 #include "base/threading/thread_checker.h"
 #include "base/time/default_tick_clock.h"
 #include "media/cast/cast_config.h"
 #include "media/cast/cast_sender.h"
 
 namespace base {
 class MessageLoopProxy;
 }  // namespace base
 
 namespace media {
 class VideoFrame;
 
 namespace cast {
 class CastEnvironment;
 class EncodingEventSubscriber;

[Ami GONE FROM CHROMIUM, 2014/02/25 18:35:08]

I think you committed a classic blunder.
Please don't rebase while there are outstanding comments as it makes
reviewing inter-patchset diffs unnecessarily difficult.
(see the _Important_ note in
http://dev.chromium.org/developers/contributing-code#TOC-The-review-process)

[mikhal1, 2014/02/25 22:33:33]

You're right, sorry.
On 2014/02/25 18:35:08, Ami Fischman wrote:

 class FrameInput;
 
 namespace transport {
 class CastTransportSender;
 }  // namespace transport
 }  // namespace cast
 }  // namespace media
 
 // This class hosts CastSender and connects it to audio/video frame input
 // and network socket.
@@ skipping 54 matching lines @@
 
   scoped_ptr<media::cast::EncodingEventSubscriber> audio_event_subscriber_;
   scoped_ptr<media::cast::EncodingEventSubscriber> video_event_subscriber_;
 
   net::IPEndPoint local_endpoint_;
   net::IPEndPoint remote_endpoint_;
   bool transport_configured_;
 
   // Proxy to the IO message loop.
   scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;
+  base::WeakPtrFactory<CastSessionDelegate> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CastSessionDelegate);
 };
 
 #endif  // CHROME_RENDERER_MEDIA_CAST_SESSION_DELEGATE_H_