src/ia32/assembler-ia32-inl.h - Issue 17418003: Short-circuit embedded cons strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32-inl.h

Issue 17418003: Short-circuit embedded cons strings. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: improved test Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/assembler-ia32-inl.h

diff --git a/src/ia32/assembler-ia32-inl.h b/src/ia32/assembler-ia32-inl.h

index 0c737acca524f3b721f107a2098e0535d5a97a6e..b6ef242a2c4e5350a0d207ce9cfcdd4fa6581217 100644

--- a/src/ia32/assembler-ia32-inl.h

+++ b/src/ia32/assembler-ia32-inl.h

@@ -132,6 +132,7 @@ Object** RelocInfo::target_object_address() {

void RelocInfo::set_target_object(Object* target, WriteBarrierMode mode) {

ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);

+ ASSERT(!target->IsConsString());

Memory::Object_at(pc_) = target;

CPU::FlushICache(pc_, sizeof(Address));

if (mode == UPDATE_WRITE_BARRIER &&

« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »