Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6276)

Unified Diff: chrome/common/origin_trials/chrome_origin_trial_policy_unittest.cc

Issue 1741783002: Add disabled origin trial feature list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/origin_trials/chrome_origin_trial_policy.cc ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/origin_trials/chrome_origin_trial_policy_unittest.cc
diff --git a/chrome/common/origin_trials/chrome_origin_trial_policy_unittest.cc b/chrome/common/origin_trials/chrome_origin_trial_policy_unittest.cc
index c7b01a05f41d856a9039c369d51c5508097e9d58..00f3a8dfc7c147c6f3979bf99b61e3fb2366fe64 100644
--- a/chrome/common/origin_trials/chrome_origin_trial_policy_unittest.cc
+++ b/chrome/common/origin_trials/chrome_origin_trial_policy_unittest.cc
@@ -28,6 +28,11 @@ const char kTooShortPublicKeyString[] =
const char kTooLongPublicKeyString[] =
"dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNAA";
+const char kOneDisabledFeature[] = "A";
+const char kTwoDisabledFeatures[] = "A|B";
+const char kThreeDisabledFeatures[] = "A|B|C";
+const char kSpacesInDisabledFeatures[] = "A|B C";
+
class ChromeOriginTrialPolicyTest : public testing::Test {
protected:
ChromeOriginTrialPolicyTest()
@@ -80,3 +85,37 @@ TEST_F(ChromeOriginTrialPolicyTest, OverrideKeyTooLong) {
EXPECT_FALSE(manager()->SetPublicKeyFromASCIIString(kTooLongPublicKeyString));
EXPECT_EQ(default_key(), manager()->GetPublicKey());
}
+
+TEST_F(ChromeOriginTrialPolicyTest, NoDisabledFeatures) {
+ EXPECT_FALSE(manager()->IsFeatureDisabled("A"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("B"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("C"));
+}
+
+TEST_F(ChromeOriginTrialPolicyTest, DisableOneFeature) {
+ EXPECT_TRUE(manager()->SetDisabledFeatures(kOneDisabledFeature));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("A"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("B"));
+}
+
+TEST_F(ChromeOriginTrialPolicyTest, DisableTwoFeatures) {
+ EXPECT_TRUE(manager()->SetDisabledFeatures(kTwoDisabledFeatures));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("A"));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("B"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("C"));
+}
+
+TEST_F(ChromeOriginTrialPolicyTest, DisableThreeFeatures) {
+ EXPECT_TRUE(manager()->SetDisabledFeatures(kThreeDisabledFeatures));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("A"));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("B"));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("C"));
+}
+
+TEST_F(ChromeOriginTrialPolicyTest, DisableFeatureWithSpace) {
+ EXPECT_TRUE(manager()->SetDisabledFeatures(kSpacesInDisabledFeatures));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("A"));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("B C"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("B"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("C"));
+}
« no previous file with comments | « chrome/common/origin_trials/chrome_origin_trial_policy.cc ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698