Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/renderer/origin_trials/origin_trial_key_manager_unittest.cc

Issue 1741783002: Add disabled origin trial feature list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Rebase; style fixes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/origin_trials/origin_trial_key_manager_unittest.cc
diff --git a/chrome/renderer/origin_trials/origin_trial_key_manager_unittest.cc b/chrome/renderer/origin_trials/origin_trial_key_manager_unittest.cc
index 962b53004c3e1df322177e7f08a379f1c9a7b497..c988c1166c681dcd8c2d2549c7df797aa71f306b 100644
--- a/chrome/renderer/origin_trials/origin_trial_key_manager_unittest.cc
+++ b/chrome/renderer/origin_trials/origin_trial_key_manager_unittest.cc
@@ -26,6 +26,11 @@ const char kTooShortPublicKeyString[] =
const char kTooLongPublicKeyString[] =
"dRCs+TocuKkocNKa0AtZ4awrt9XKH2SQCI6o4FY6BNAA";
+const char kOneDisabledFeature[] = "A";
+const char kTwoDisabledFeatures[] = "A|B";
+const char kThreeDisabledFeatures[] = "A|B|C";
+const char kSpacesInDisabledFeatures[] = "A|B C";
+
class OriginTrialKeyManagerTest : public testing::Test {
protected:
OriginTrialKeyManagerTest()
@@ -78,3 +83,37 @@ TEST_F(OriginTrialKeyManagerTest, OverrideKeyTooLong) {
EXPECT_FALSE(manager()->SetPublicKeyFromASCIIString(kTooLongPublicKeyString));
EXPECT_EQ(default_key(), manager()->GetPublicKey());
}
+
+TEST_F(OriginTrialKeyManagerTest, NoDisabledFeatures) {
+ EXPECT_FALSE(manager()->IsFeatureDisabled("A"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("B"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("C"));
+}
+
+TEST_F(OriginTrialKeyManagerTest, DisableOneFeature) {
+ EXPECT_TRUE(manager()->SetDisabledFeatures(kOneDisabledFeature));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("A"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("B"));
+}
+
+TEST_F(OriginTrialKeyManagerTest, DisableTwoFeatures) {
+ EXPECT_TRUE(manager()->SetDisabledFeatures(kTwoDisabledFeatures));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("A"));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("B"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("C"));
+}
+
+TEST_F(OriginTrialKeyManagerTest, DisableThreeFeatures) {
+ EXPECT_TRUE(manager()->SetDisabledFeatures(kThreeDisabledFeatures));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("A"));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("B"));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("C"));
+}
+
+TEST_F(OriginTrialKeyManagerTest, DisableFeatureWithSpace) {
+ EXPECT_TRUE(manager()->SetDisabledFeatures(kSpacesInDisabledFeatures));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("A"));
+ EXPECT_TRUE(manager()->IsFeatureDisabled("B C"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("B"));
+ EXPECT_FALSE(manager()->IsFeatureDisabled("C"));
+}

Powered by Google App Engine
This is Rietveld 408576698