Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2168)

Unified Diff: content/public/common/content_client.h

Issue 1741783002: Add disabled origin trial feature list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Separate the introduction of preference-persistence into a different CL Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/content_client.h
diff --git a/content/public/common/content_client.h b/content/public/common/content_client.h
index 5510cb27f9145e769ea02cf7df17502e72cafe1a..a39f02239af621710ae3943f2b2590d4c5117657 100644
--- a/content/public/common/content_client.h
+++ b/content/public/common/content_client.h
@@ -177,6 +177,10 @@ class CONTENT_EXPORT ContentClient {
// origin trials are not enabled in this context.
virtual base::StringPiece GetOriginTrialPublicKey();
+ // Returns true if the named experimental feature should be disabled in origin
+ // trials, even if a valid token is present.
+ virtual bool IsOriginTrialFeatureDisabled(base::StringPiece feature);
chasej 2016/06/07 15:51:31 With additional methods, would it make sense to co
Sorin Jianu 2016/06/07 17:20:24 can the virtual function be declared const?
iclelland 2016/06/08 13:37:56 Yes, and GetOriginTrialPublicKey above it.
iclelland 2016/06/08 15:38:52 I've made that refactor in a follow-up CL; see the
+
#if defined(OS_ANDROID)
// Returns true for clients like Android WebView that uses synchronous
// compositor. Note setting this to true will permit synchronous IPCs from

Powered by Google App Engine
This is Rietveld 408576698