Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp

Issue 1741783002: Add disabled origin trial feature list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ef-finch
Patch Set: Rebase; fix after crrev.com/cb60e703 landed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
diff --git a/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
index f19a442252bc43be50a4f9c8fb0a8a40ca42f889..e0cc52e4724ea9f550bde00ef7896de58e5e06d2 100644
--- a/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
+++ b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
@@ -71,7 +71,8 @@ int getTokenValidationResultPriority(
// 5. Wrong version for token (not currently supported version number(s))
// 6. Invalid data in token (can be before/after validating signature)
// 7. Embedder does not support origin trials
- // 8. No tokens provided
+ // 8. The feature requested is disabled
+ // 9. No tokens provided
// NOTE: Lower numbers are higher priority
// See this document for details:
// https://docs.google.com/document/d/1qVP2CK1lbfmtIJRIm6nwuEFFhGhYbtThLQPo3CSTtmg/edit#bookmark=id.k1j0q938so3b
@@ -95,8 +96,10 @@ int getTokenValidationResultPriority(
return 6;
case WebOriginTrialTokenStatus::NotSupported:
return 7;
- case WebOriginTrialTokenStatus::NoTokens:
+ case WebOriginTrialTokenStatus::FeatureDisabled:
return 8;
+ case WebOriginTrialTokenStatus::NoTokens:
+ return 9;
}
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698