Add disabled origin trial feature list

content/public/common/content_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_
 #define CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 159 matching lines @@
 
   // Called by the renderer after the render thread has started, and allows the
   // embedder to set up any global origin trial policies (custom public key, or
   // disabled experiments)
   virtual void InitializeOriginTrialPolicy();
 
   // Returns the public key to be used for origin trials, or an empty string if
   // origin trials are not enabled in this context.
   virtual base::StringPiece GetOriginTrialPublicKey();
 
+  // Returns true if the named experimental feature should be disabled in origin
+  // trials, even if a valid token is present.
+  virtual bool IsOriginTrialFeatureDisabled(base::StringPiece feature);

[chasej, 2016/06/07 15:51:31]

With additional methods, would it make sense to collect them into a single class
(e.g. OriginTrialPolicy)? Then, could just expose the class (similar to
GetMediaClientAndroid below). The base class could provide the default
implementation (rather than making content_client.cc do so), and be overridden
as necessary.

I'm not sure that's the best thing to do, just asking the question.

[Sorin Jianu, 2016/06/07 17:20:24]

can the virtual function be declared const?

[iclelland, 2016/06/08 13:37:56]

Yes, and GetOriginTrialPublicKey above it.

[iclelland, 2016/06/08 15:38:52]

I've made that refactor in a follow-up CL; see the result here:
https://codereview.chromium.org/2049783002

+
 #if defined(OS_ANDROID)
   // Returns true for clients like Android WebView that uses synchronous
   // compositor. Note setting this to true will permit synchronous IPCs from
   // the browser UI thread.
   virtual bool UsingSynchronousCompositing();
 
   // Returns the MediaClientAndroid to be used by media code on Android.
   virtual media::MediaClientAndroid* GetMediaClientAndroid();
 #endif  // OS_ANDROID
 
  private:
   friend class ContentClientInitializer;  // To set these pointers.
   friend class InternalTestInitializer;
 
   // The embedder API for participating in browser logic.
   ContentBrowserClient* browser_;
   // The embedder API for participating in gpu logic.
   ContentGpuClient* gpu_;
   // The embedder API for participating in renderer logic.
   ContentRendererClient* renderer_;
   // The embedder API for participating in utility logic.
   ContentUtilityClient* utility_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_CONTENT_CLIENT_H_