Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 174169: Remove a bunch of platform specific test results and remove failing tests fro... (Closed)

Created:
11 years, 4 months ago by Julie Parent
Modified:
9 years, 7 months ago
Reviewers:
eseidel
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Remove a bunch of platform specific test results and remove failing tests from test-expectations. These layout tests were re-written in: http://trac.webkit.org/changeset/47544 http://trac.webkit.org/changeset/47543 http://trac.webkit.org/changeset/47542 http://trac.webkit.org/changeset/47533 to not be pixel tests but instead just be text dumps. Thus we do not need any platform specfic results. TEST=ran manually locally BUG=19796 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -624 lines) Patch
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-across-paragraph-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-across-paragraph-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-after-paragraph-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-after-paragraph-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/underline-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/underline-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-expected.txt View 1 chunk +0 lines, -118 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt View 1 chunk +0 lines, -120 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-expected.txt View 1 chunk +0 lines, -103 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt View 1 chunk +0 lines, -105 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-expected.txt View 1 chunk +0 lines, -86 lines 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/underline-expected.checksum View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/underline-expected.png View Binary file 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/underline-expected.txt View 1 chunk +0 lines, -74 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Julie Parent
11 years, 4 months ago (2009-08-20 20:51:07 UTC) #1
eseidel
11 years, 4 months ago (2009-08-20 21:12:42 UTC) #2
LGTM.

On Thu, Aug 20, 2009 at 1:51 PM, <jparent@chromium.org> wrote:

> Reviewers: Eric Seidel (Google),
>
> Description:
> Remove a bunch of platform specific test results and remove failing
> tests from test-expectations.  These layout tests were re-written in:
> http://trac.webkit.org/changeset/47544
> http://trac.webkit.org/changeset/47543
> http://trac.webkit.org/changeset/47542
> http://trac.webkit.org/changeset/47533
>
> to not be pixel tests but instead just be text dumps.  Thus we do not
> need any platform specfic results.
>
> TEST=ran manually locally
> BUG=19796
>
>
> Please review this at http://codereview.chromium.org/174169
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-across-paragraph-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-across-paragraph-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-after-paragraph-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-after-paragraph-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/remove-underline-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/underline-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/style/underline-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-expected.txt
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-expected.txt
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/remove-underline-expected.txt
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/underline-expected.checksum
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/underline-expected.png
>  D
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/underline-expected.txt
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
>

Powered by Google App Engine
This is Rietveld 408576698