Revert of Refactoring: Move some classes from content/child to platform (patchset #17 id:320001 of …

Revert of Refactoring: Move some classes from content/child to platform (patchset #17 id:320001 of https://codereview.chromium.org/1660383002/ )

Reason for revert: this is breaking all sort of things:
 - This CL makes perf benchmarks fail on several platforms.
    (https://chromeperf.appspot.com/group_report?bug_id=589850)
 - Makes memory-infra dump crash.
 - Also caused some GCC linker error as reported in the comments of
   crrev.com/1660383002.

Original issue's description:
> Refactoring: Move some classes from content/child to platform
>
> This CL moves these classes:
> - WebMemoryAllocatorDumpImpl
> - WebMemoryDumpProviderAdapter
> - WebProcessMemoryDumpImpl(Test)
> from content/child to platform. Now that platform can depend on base,
> we don't need adapter classes in Chromium side.
>
> After this CL, we will be able to reduce glue classes by unifying:
> - WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl
> - WebProcessMemoryDump and WebProcessMemoryDumpImpl
> - WebMemoryDumpProvider and WebMemoryDumpProviderAdapter
> so that we can reduce lots of code.
>
> BUG=548254
>
> Committed: https://crrev.com/a8227af5f6016e10e78b539ffa55aeb634ca7601
> Cr-Commit-Position: refs/heads/master@{#377552}

TBR=tkent@chromium.org,bashi@chromium.org,esprehn@chromium.org,haraken@chromium.org,kinuko@chromium.org,primiano@chromium.org,thakis@chromium.org,xhwang@chromium.org,hajimehoshi@chromium.org
NOPRESUBMIT=true
BUG=548254

[Primiano Tucci (use gerrit), 2016-02-26 03:24:57]

Description was changed from

==========
Revert of Refactoring: Move some classes from content/child to platform
(patchset #17 id:320001 of https://codereview.chromium.org/1660383002/ )

Reason for revert:
This CL makes perf benchmarks fail on several platforms.
Also caused some GCC linker error as reported in the comments of
crrev.com/1660383002.

The bisect result:
https://chromeperf.appspot.com/group_report?bug_id=589850

Original issue's description:
> Refactoring: Move some classes from content/child to platform
>
> This CL moves these classes:
> - WebMemoryAllocatorDumpImpl
> - WebMemoryDumpProviderAdapter
> - WebProcessMemoryDumpImpl(Test)
> from content/child to platform. Now that platform can depend on base,
> we don't need adapter classes in Chromium side.
>
> After this CL, we will be able to reduce glue classes by unifying:
> - WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl
> - WebProcessMemoryDump and WebProcessMemoryDumpImpl
> - WebMemoryDumpProvider and WebMemoryDumpProviderAdapter
> so that we can reduce lots of code.
>
> BUG=548254
>
> Committed: https://crrev.com/a8227af5f6016e10e78b539ffa55aeb634ca7601
> Cr-Commit-Position: refs/heads/master@{#377552}

TBR=tkent@chromium.org,bashi@chromium.org,esprehn@chromium.org,haraken@chromi...
NOPRESUBMIT=true
BUG=548254
==========

to

==========
Revert of Refactoring: Move some classes from content/child to platform
(patchset #17 id:320001 of https://codereview.chromium.org/1660383002/ )

Reason for revert: this is breaking all sort of things:
 - This CL makes perf benchmarks fail on several platforms.
    (https://chromeperf.appspot.com/group_report?bug_id=589850)
 - Makes memory-infra dump crash.
 - Also caused some GCC linker error as reported in the comments of
   crrev.com/1660383002.

Original issue's description:
> Refactoring: Move some classes from content/child to platform
>
> This CL moves these classes:
> - WebMemoryAllocatorDumpImpl
> - WebMemoryDumpProviderAdapter
> - WebProcessMemoryDumpImpl(Test)
> from content/child to platform. Now that platform can depend on base,
> we don't need adapter classes in Chromium side.
>
> After this CL, we will be able to reduce glue classes by unifying:
> - WebMemoryAllocatorDump and WebMemoryAllocatorDumpImpl
> - WebProcessMemoryDump and WebProcessMemoryDumpImpl
> - WebMemoryDumpProvider and WebMemoryDumpProviderAdapter
> so that we can reduce lots of code.
>
> BUG=548254
>
> Committed: https://crrev.com/a8227af5f6016e10e78b539ffa55aeb634ca7601
> Cr-Commit-Position: refs/heads/master@{#377552}

TBR=tkent@chromium.org,bashi@chromium.org,esprehn@chromium.org,haraken@chromi...
NOPRESUBMIT=true
BUG=548254
==========

[Primiano Tucci (use gerrit), 2016-02-26 03:26:19]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-02-26 03:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1741673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1741673002/1

[Primiano Tucci (use gerrit), 2016-02-26 04:06:43]

The CQ bit was unchecked by primiano@chromium.org

[Zhen Wang, 2016-02-26 16:40:16]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-02-26 16:41:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1741673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1741673002/1

[Zhen Wang, 2016-02-26 16:43:37]

The CQ bit was unchecked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-02-26 16:45:39]

The CQ bit was unchecked by commit-bot@chromium.org

[Zhen Wang, 2016-02-26 16:48:52]

Just saw the email thread that it is fixed in another CL. Thanks, Primiano!

[Primiano Tucci (use gerrit), 2016-02-26 16:50:07]

On 2016/02/26 16:41:56, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1741673002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1741673002/1

I think this might not be necessary anymore after
https://codereview.chromium.org/1731893004/
See perf-sheriffs@ mail in
https://groups.google.com/a/chromium.org/forum/#!topic/perf-sheriffs/qzBBC3xvQzk

[xhwang, 2016-02-26 18:21:22]

xhwang@chromium.org changed reviewers:
- xhwang@chromium.org

[Zhen Wang, 2016-06-01 22:21:51]

zhenw@chromium.org changed reviewers:
- zhenw@chromium.org