Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1741663003: Remove more methods from context manager callbacks (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -52 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 6 chunks +26 lines, -35 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 6 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-26 22:49:18 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-26 22:51:14 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-02-29 18:43:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d9aa3edf4e70f13b9759823c08958b4f4947113 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698