Chromium Code Reviews Chromium Code Reviews
Issue 17416003:
Adding 3 new SSL experimental conditions (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/resources/ssl/roadblock.html |
| diff --git a/chrome/browser/resources/ssl/roadblock.html b/chrome/browser/resources/ssl/roadblock.html |
| index 28b77f584848132c3113f5737e011673f6575f71..afdec25ccbcdc449874320aa16c79789929ffe8c 100644 |
| --- a/chrome/browser/resources/ssl/roadblock.html |
| +++ b/chrome/browser/resources/ssl/roadblock.html |
| @@ -61,6 +61,14 @@ |
| text-decoration: underline; |
| } |
| + .test-image { |
| + float: right; |
| + height: 140px; |
| + padding-left: 30px; |
| + padding-right: 30px; |
| + width: 140px; |
| + } |
| + |
|
Dan Beam
2013/06/20 17:52:12
html[dir='rtl'] .test-image {
float: left;
}
felt
2013/06/20 19:57:59
Done.
|
| .title { |
| color: #660000; |
| font-size: 18pt; |
| @@ -160,8 +168,25 @@ |
| }); |
| } |
| + function setupIconExperiments() { |
|
Dan Beam
2013/06/20 17:52:12
nit: the JS haxor way that also works in RTL -
va
Dan Beam
2013/06/20 17:52:12
can you ensure this isn't called multiple times or
felt
2013/06/20 19:57:59
I added a boolean.
On 2013/06/20 17:52:12, Dan Be
felt
2013/06/20 19:57:59
Done.
|
| + if (templateData.trialType == 'Condition19SSLPoliceman') { |
| + $('trial-policeman').hidden = false; |
| + $('more-info-short').style.marginRight = '30px'; |
| + $('more-info-long').style.marginRight = '30px'; |
| + } else if (templateData.trialType == 'Condition20SSLStoplight') { |
| + $('trial-stoplight').hidden = false; |
| + $('more-info-short').style.marginRight = '30px'; |
| + $('more-info-long').style.marginRight = '30px'; |
| + } else if (templateData.trialType == 'Condition21SSLBadguy') { |
| + $('trial-badguy').hidden = false; |
| + $('more-info-short').style.marginRight = '30px'; |
| + $('more-info-long').style.marginRight = '30px'; |
| + } |
| + } |
| + |
| window.addEventListener('focus', handleFocusEvent); |
| document.addEventListener('DOMContentLoaded', setupEvents); |
| + document.addEventListener('DOMContentLoaded', setupIconExperiments); |
| </script> |
| </head> |
| <body> |
| @@ -170,6 +195,18 @@ |
| <img src="roadblock_icon.png" alt="SSL Error Icon" id="roadblock-icon"> |
| </div> |
| <div class="title" i18n-content="headLine"></div> |
| + |
| + <!-- RHS images for the field trial. --> |
| + <div id="trial-badguy" class="test-image" hidden> |
| + <img src="badguy.png" alt="Bad guy"> |
| + </div> |
| + <div id="trial-policeman" class="test-image" hidden> |
| + <img src="policeman.png" alt="Policeman"> |
| + </div> |
| + <div id="trial-stoplight" class="test-image" hidden> |
| + <img src="stoplight.png" alt="Stoplight"> |
| + </div> |
| + |
| <div class="main" i18n-values=".innerHTML:description;dir:textdirection"></div> |
| <div class="main" i18n-values=".innerHTML:reasonForNotProceeding"></div> |
| <div class="main"> |
