Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: src/regexp-macro-assembler-tracer.cc

Issue 17416: * Move irregexp backtrack stack to external memory area, instead of the system stack. (Closed)
Patch Set: Added explicit stack check requests to push operations. Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/regexp-macro-assembler-tracer.cc
diff --git a/src/regexp-macro-assembler-tracer.cc b/src/regexp-macro-assembler-tracer.cc
index 2eb7ec58f3e9f51e5549b2bd0e1222005b7b024e..0ae148c8241d3ac0bf5cdb2a672e2a21d4f72eea 100644
--- a/src/regexp-macro-assembler-tracer.cc
+++ b/src/regexp-macro-assembler-tracer.cc
@@ -76,9 +76,11 @@ void RegExpMacroAssemblerTracer::PopCurrentPosition() {
}
-void RegExpMacroAssemblerTracer::PushCurrentPosition() {
- PrintF(" PushCurrentPosition();\n");
- assembler_->PushCurrentPosition();
+void RegExpMacroAssemblerTracer::PushCurrentPosition(
+ StackCheckFlag check_stack_limit) {
+ PrintF(" PushCurrentPosition(%s);\n",
+ check_stack_limit ? "check stack limit" : "");
+ assembler_->PushCurrentPosition(check_stack_limit);
}
@@ -94,9 +96,13 @@ void RegExpMacroAssemblerTracer::GoTo(Label* label) {
}
-void RegExpMacroAssemblerTracer::PushBacktrack(Label* label) {
- PrintF(" PushBacktrack(label[%08x]);\n", label);
- assembler_->PushBacktrack(label);
+void RegExpMacroAssemblerTracer::PushBacktrack(
+ Label* label,
+ StackCheckFlag check_stack_limit) {
+ PrintF(" PushBacktrack(label[%08x], %s);\n",
+ label,
+ check_stack_limit ? "check stack limit" : "");
+ assembler_->PushBacktrack(label, check_stack_limit);
}
@@ -118,9 +124,13 @@ void RegExpMacroAssemblerTracer::PopRegister(int register_index) {
}
-void RegExpMacroAssemblerTracer::PushRegister(int register_index) {
- PrintF(" PushRegister(register=%d);\n", register_index);
- assembler_->PushRegister(register_index);
+void RegExpMacroAssemblerTracer::PushRegister(
+ int register_index,
+ StackCheckFlag check_stack_limit) {
+ PrintF(" PushRegister(register=%d, %s);\n",
+ register_index,
+ check_stack_limit ? "check stack limit" : "");
+ assembler_->PushRegister(register_index, check_stack_limit);
}

Powered by Google App Engine
This is Rietveld 408576698