Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: src/regexp-macro-assembler-irregexp.cc

Issue 17416: * Move irregexp backtrack stack to external memory area, instead of the system stack. (Closed)
Patch Set: Added explicit stack check requests to push operations. Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/regexp-macro-assembler-irregexp.cc
diff --git a/src/regexp-macro-assembler-irregexp.cc b/src/regexp-macro-assembler-irregexp.cc
index e2bed27ee40b1e4523a89e120904b3f3b9468da4..552eb1d4dc958a4d08f0e93dc6e238d777a527b8 100644
--- a/src/regexp-macro-assembler-irregexp.cc
+++ b/src/regexp-macro-assembler-irregexp.cc
@@ -89,7 +89,9 @@ void RegExpMacroAssemblerIrregexp::PopRegister(int register_index) {
}
-void RegExpMacroAssemblerIrregexp::PushRegister(int register_index) {
+void RegExpMacroAssemblerIrregexp::PushRegister(
+ int register_index,
+ StackCheckFlag check_stack_limit) {
ASSERT(register_index >= 0);
Emit(BC_PUSH_REGISTER);
Emit(register_index);
@@ -150,7 +152,8 @@ void RegExpMacroAssemblerIrregexp::PopCurrentPosition() {
}
-void RegExpMacroAssemblerIrregexp::PushCurrentPosition() {
+void RegExpMacroAssemblerIrregexp::PushCurrentPosition(
+ StackCheckFlag check_stack_limit) {
Emit(BC_PUSH_CP);
Emit32(0); // Current position offset.
}
@@ -167,7 +170,9 @@ void RegExpMacroAssemblerIrregexp::GoTo(Label* l) {
}
-void RegExpMacroAssemblerIrregexp::PushBacktrack(Label* l) {
+void RegExpMacroAssemblerIrregexp::PushBacktrack(
+ Label* l,
+ StackCheckFlag check_stack_limit) {
Emit(BC_PUSH_BT);
EmitOrLink(l);
}

Powered by Google App Engine
This is Rietveld 408576698