Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1741513002: Revert of gpu: Expose internal format R8 instead of RED. (Closed)

Created:
4 years, 10 months ago by Daniele Castagna
Modified:
4 years, 10 months ago
CC:
ccameron, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Expose internal format R8 instead of RED. (patchset #8 id:140001 of https://codereview.chromium.org/1708263002/ ) Reason for revert: This broke videos on windows: crbug.com/589775 Original issue's description: > gpu: Expose internal format R8 instead of RED. > > As noted in crrev.com/1703153002 GL_R8 sized internalformat should be preferred to > GL_RED. > > This CL lets the users of the command buffer use GL_R8, and it takes care of > converting it to GL_RED when not supported by the underlying GL context. > > BUG= > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/7b277c596c517ce4a5d0985ace0da1806f2470f4 > Cr-Commit-Position: refs/heads/master@{#377222} TBR=dalecurtis@chromium.org,reveman@chromium.org,zmo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/ecfa963e574cc83d138ded8ebf523275e667d733 Cr-Commit-Position: refs/heads/master@{#377682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M cc/resources/resource_format.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt View 3 chunks +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/image_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.mm View 3 chunks +2 lines, -5 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Daniele Castagna
Created Revert of gpu: Expose internal format R8 instead of RED.
4 years, 10 months ago (2016-02-25 20:22:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741513002/1
4 years, 10 months ago (2016-02-25 20:25:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741513002/1
4 years, 10 months ago (2016-02-25 20:33:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741513002/1
4 years, 10 months ago (2016-02-25 21:03:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741513002/1
4 years, 10 months ago (2016-02-25 21:34:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 22:00:47 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 22:02:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecfa963e574cc83d138ded8ebf523275e667d733
Cr-Commit-Position: refs/heads/master@{#377682}

Powered by Google App Engine
This is Rietveld 408576698