base/memory/discardable_shared_memory_unittest.cc - Issue 1741403002: base: Avoid calling VirtualAlloc with 0 length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/discardable_shared_memory_unittest.cc

Issue 1741403002: base: Avoid calling VirtualAlloc with 0 length. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: keep most of unit test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/discardable_shared_memory_unittest.cc

diff --git a/base/memory/discardable_shared_memory_unittest.cc b/base/memory/discardable_shared_memory_unittest.cc

index f55479b05efaf5c42c87c5f7a6c0285228c31dab..4c55d54de21dc6c2fc10d8c451df0abeb2c71604 100644

--- a/base/memory/discardable_shared_memory_unittest.cc

+++ b/base/memory/discardable_shared_memory_unittest.cc

@@ -358,7 +358,7 @@ TEST(DiscardableSharedMemoryTest, ZeroSize) {

// Lock and unlock memory.

DiscardableSharedMemory::LockResult lock_rv = memory.Lock(0, 0);

- EXPECT_EQ(DiscardableSharedMemory::SUCCESS, lock_rv);

+ EXPECT_NE(DiscardableSharedMemory::FAILED, lock_rv);

memory.SetNow(Time::FromDoubleT(2));

memory.Unlock(0, 0);

}