Refactor: clean up some unused or mostly-unused API I saw here.

tests/Test.h

Index: tests/Test.h
diff --git a/tests/Test.h b/tests/Test.h
index 8cb23c1b48b2728a83cb582621f54845f6705700..039acb8622a6334fe9877d5283bcc25a7ea54600 100644
--- a/tests/Test.h
+++ b/tests/Test.h
@@ -35,22 +35,13 @@ namespace skiatest {
         int countTests() const { return fTestCount; }
 
         void startTest(Test*);
-        void report(const char testDesc[], Result);
+        void reportFailed(const SkString& desc);
         void endTest(Test*);
 
         virtual bool allowExtendedTest() const { return false; }
         virtual bool allowThreaded() const { return false; }
         virtual void bumpTestCount() { sk_atomic_inc(&fTestCount); }
 
-        // helpers for tests
-        void reportFailed(const char desc[]) {
-            this->report(desc, kFailed);
-        }
-        void reportFailed(const SkString& desc) {
-            this->report(desc.c_str(), kFailed);
-        }
-
-
     protected:
         virtual void onStart(Test*) {}
         virtual void onReport(const char desc[], Result) {}

[bungeman-skia, 2013/06/18 19:52:33]

Since we might be mucking with onReport anyway, it should also take const
SkString& if report does. There appear to be only two existing implementations.
The DebugfReporter can just c_str() and the LocalReporter can use
push_back(desc) instead of push_back().set(desc) for better performance. Since
Result is abandoned, this it might as well be renamed onReportFailed while we're
at it.

[mtklein, 2013/06/18 20:02:47]

Done.