Refactor: clean up some unused or mostly-unused API I saw here.

Refactor: clean up some unused or mostly-unused API I saw here.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=9668

[mtklein, 2013-06-18 17:55:36]

In the spirit of unifying code that does the same thing...

Tested: ./gyp_skia && ninja -C out/Debug/ && out/Debug/tests

[reed1, 2013-06-18 19:41:10]

lgtm

[bungeman-skia, 2013-06-18 19:52:32]

Some consistency / dead code issues.

https://codereview.chromium.org/17414003/diff/1/tests/Test.h
File tests/Test.h (right):

https://codereview.chromium.org/17414003/diff/1/tests/Test.h#newcode28
tests/Test.h:28: enum Result {
This enum doesn't appear to be used anymore, it should probably be removed.

This also means removing result2string from skia_test.cpp and changing the
onReport signature.

https://codereview.chromium.org/17414003/diff/1/tests/Test.h#newcode47
tests/Test.h:47: virtual void onReport(const char desc[], Result) {}
Since we might be mucking with onReport anyway, it should also take const
SkString& if report does. There appear to be only two existing implementations.
The DebugfReporter can just c_str() and the LocalReporter can use
push_back(desc) instead of push_back().set(desc) for better performance. Since
Result is abandoned, this it might as well be renamed onReportFailed while we're
at it.

[mtklein, 2013-06-18 20:02:46]

Good calls. Please take another look.

https://codereview.chromium.org/17414003/diff/1/tests/Test.h
File tests/Test.h (right):

https://codereview.chromium.org/17414003/diff/1/tests/Test.h#newcode28
tests/Test.h:28: enum Result {
On 2013/06/18 19:52:33, bungeman1 wrote:
> This enum doesn't appear to be used anymore, it should probably be removed.
> 
> This also means removing result2string from skia_test.cpp and changing the
> onReport signature.

Done.

https://codereview.chromium.org/17414003/diff/1/tests/Test.h#newcode47
tests/Test.h:47: virtual void onReport(const char desc[], Result) {}
On 2013/06/18 19:52:33, bungeman1 wrote:
> Since we might be mucking with onReport anyway, it should also take const
> SkString& if report does. There appear to be only two existing
implementations.
> The DebugfReporter can just c_str() and the LocalReporter can use
> push_back(desc) instead of push_back().set(desc) for better performance. Since
> Result is abandoned, this it might as well be renamed onReportFailed while
we're
> at it.

Done.

[bungeman-skia, 2013-06-18 20:33:53]

LGTM at Patch Set 2.

[commit-bot: I haz the power, 2013-06-18 20:42:02]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/17414003/6001

[commit-bot: I haz the power, 2013-06-18 20:50:36]

Change committed as 9668