Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: src/virtual-frame-ia32.cc

Issue 17414: Add register allocation for a lot of calls. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/codegen-ia32.cc ('K') | « src/codegen-ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/virtual-frame-ia32.cc
===================================================================
--- src/virtual-frame-ia32.cc (revision 1042)
+++ src/virtual-frame-ia32.cc (working copy)
@@ -250,10 +250,16 @@
void VirtualFrame::PrepareForCall(int frame_arg_count) {
ASSERT(height() >= frame_arg_count);
- // Below the stack pointer, spill all registers.
+ // Below the stack pointer, spill all registers and make sure that
+ // locals have the right values by sync'ing them. The sync'ing is
+ // necessary to give the debugger a consistent view of the values of
+ // locals in the frame.
for (int i = 0; i <= stack_pointer_; i++) {
- if (elements_[i].is_register()) {
+ FrameElement element = elements_[i];
+ if (element.is_register()) {
SpillElementAt(i);
+ } else if (element.is_valid() && i < expression_base_index()) {
+ SyncElementAt(i);
}
}
« src/codegen-ia32.cc ('K') | « src/codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698