Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1758)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 17413016: Fix overscroll glow when the FIP dialog is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Explicit enable on creation Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/android/overscroll_glow.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 46748208f0f8533e8efe3fbdcbccb5248509446b..1b0dbe86065025dd406ace277be93b035b215ba6 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -296,15 +296,16 @@ void RenderWidgetHostViewAndroid::Focus() {
host_->Focus();
host_->SetInputMethodActive(true);
ResetClipping();
+ if (overscroll_effect_)
+ overscroll_effect_->SetEnabled(true);
}
void RenderWidgetHostViewAndroid::Blur() {
host_->ExecuteEditCommand("Unselect", "");
host_->SetInputMethodActive(false);
host_->Blur();
-
if (overscroll_effect_)
- overscroll_effect_->Finish();
+ overscroll_effect_->SetEnabled(false);
}
bool RenderWidgetHostViewAndroid::HasFocus() const {
@@ -739,7 +740,7 @@ void RenderWidgetHostViewAndroid::RemoveLayers() {
}
bool RenderWidgetHostViewAndroid::Animate(base::TimeTicks frame_time) {
- if (!overscroll_effect_ || !HasFocus())
+ if (!overscroll_effect_)
return false;
return overscroll_effect_->Animate(frame_time);
}
@@ -748,7 +749,7 @@ void RenderWidgetHostViewAndroid::CreateOverscrollEffectIfNecessary() {
if (!overscroll_effect_enabled_ || overscroll_effect_)
return;
- overscroll_effect_ = OverscrollGlow::Create();
+ overscroll_effect_ = OverscrollGlow::Create(true);
// Prevent future creation attempts on failure.
if (!overscroll_effect_)
@@ -775,7 +776,7 @@ void RenderWidgetHostViewAndroid::UpdateAnimationSize(
void RenderWidgetHostViewAndroid::ScheduleAnimationIfNecessary() {
if (!content_view_core_)
return;
- if (overscroll_effect_ && overscroll_effect_->IsActive())
+ if (overscroll_effect_ && overscroll_effect_->NeedsAnimate())
content_view_core_->SetNeedsAnimate();
}
@@ -963,6 +964,10 @@ void RenderWidgetHostViewAndroid::SendMouseWheelEvent(
void RenderWidgetHostViewAndroid::SendGestureEvent(
const WebKit::WebGestureEvent& event) {
+ // Sending a gesture that may trigger overscroll should resume the effect.
+ if (overscroll_effect_)
+ overscroll_effect_->SetEnabled(true);
+
if (host_)
host_->ForwardGestureEvent(event);
}
@@ -1030,7 +1035,7 @@ void RenderWidgetHostViewAndroid::OnOverscrolled(
gfx::Vector2dF accumulated_overscroll,
gfx::Vector2dF current_fling_velocity) {
CreateOverscrollEffectIfNecessary();
- if (!overscroll_effect_ || !HasFocus())
+ if (!overscroll_effect_)
return;
overscroll_effect_->OnOverscrolled(base::TimeTicks::Now(),
« no previous file with comments | « content/browser/android/overscroll_glow.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698