Issue 17413014: Revert 207802 "bookmarks: Convert "Remove" link into a LabelButton."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17413014: Revert 207802 "bookmarks: Convert "Remove" link into a LabelButton." (Closed)

Created:
7 years, 6 months ago by Dmitry Zvorygin

Modified:
7 years, 6 months ago

Reviewers:
tfarina

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 207802 "bookmarks: Convert "Remove" link into a LabelButton." > bookmarks: Convert "Remove" link into a LabelButton. > > This also tweaked all the paddings/spacings all around to make the bubble really closer to the mocks. > > BUG=231694 > TEST=ctrl+D or press the star button in the omnibox, observe the Bookmark Bubble, > there should be a "Remove" Button in the left side of "Edit.." button. > R=msw@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/16279002 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207804

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -66 lines)			Patch
M	trunk/src/chrome/app/bookmarks_strings.grdp	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h	View	4 chunks	+8 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc	View	8 chunks	+63 lines, -54 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r207804.