Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 174113003: Fix issue with setting __proto__ on a value (Closed)

Created:
6 years, 10 months ago by arv (Not doing code reviews)
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issue with setting __proto__ on a value LOG=N BUG=v8:3172 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/proto-accessor.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
arv (Not doing code reviews)
6 years, 10 months ago (2014-02-20 21:10:18 UTC) #1
Michael Starzinger
LGTM.
6 years, 10 months ago (2014-02-24 09:43:38 UTC) #2
Michael Starzinger
(will land as soon as tree is open again)
6 years, 10 months ago (2014-02-24 10:01:55 UTC) #3
arv (Not doing code reviews)
Thanks
6 years, 10 months ago (2014-02-24 15:51:55 UTC) #4
arv (Not doing code reviews)
Did this land?
6 years, 9 months ago (2014-03-04 17:33:12 UTC) #5
Michael Starzinger
Nope, not yet, tree still closed. But titzer@ (CCed) is sheriff this week, if you ...
6 years, 9 months ago (2014-03-04 18:36:46 UTC) #6
arv (Not doing code reviews)
On 2014/03/04 18:36:46, Michael Starzinger wrote: > Nope, not yet, tree still closed. But titzer@ ...
6 years, 9 months ago (2014-03-04 18:54:53 UTC) #7
titzer
On 2014/03/04 18:54:53, arv wrote: > On 2014/03/04 18:36:46, Michael Starzinger wrote: > > Nope, ...
6 years, 9 months ago (2014-03-05 08:51:29 UTC) #8
Michael Starzinger
Committed patchset #1 manually as r19666 (tree was closed).
6 years, 9 months ago (2014-03-05 08:58:44 UTC) #9
arv (Not doing code reviews)
6 years, 9 months ago (2014-03-05 15:52:21 UTC) #10
Message was sent while issue was closed.
On 2014/03/05 08:51:29, titzer wrote:
> On 2014/03/04 18:54:53, arv wrote:
> > On 2014/03/04 18:36:46, Michael Starzinger wrote:
> > > Nope, not yet, tree still closed. But titzer@ (CCed) is sheriff this week,
> if
> > > you can convince him that the change is "not risky", then I can land.
> > 
> > It is not urgent. It only breaks things like `42 .__proto__ = {}`... but on
> the
> > other hand it is low risk ;-)
> 
> Sheriff says: land it!

Thanks

Powered by Google App Engine
This is Rietveld 408576698