Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: components/offline_pages/offline_page_model.cc

Issue 1741123002: Add removal filter support for Cookies, Storage, and Content Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added offline pages test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.cc
diff --git a/components/offline_pages/offline_page_model.cc b/components/offline_pages/offline_page_model.cc
index af089d4d4edbb6a5e2a5c35af14898c8b31d5842..3fdcee572508022250c6de0ef9a253ca143bc008 100644
--- a/components/offline_pages/offline_page_model.cc
+++ b/components/offline_pages/offline_page_model.cc
@@ -288,6 +288,33 @@ void OfflinePageModel::ClearAll(const base::Closure& callback) {
weak_ptr_factory_.GetWeakPtr(), callback));
}
+void OfflinePageModel::DeletePagesByURLPredicate(
+ const base::Callback<bool(const GURL&)> predicate,
+ const DeletePageCallback& callback) {
+ if (!is_loaded_) {
+ delayed_tasks_.push_back(
+ base::Bind(&OfflinePageModel::DoDeletePagesByURLPredicate,
+ weak_ptr_factory_.GetWeakPtr(), predicate, callback));
+
+ return;
+ }
+ DoDeletePagesByURLPredicate(predicate, callback);
+}
+
+void OfflinePageModel::DoDeletePagesByURLPredicate(
+ const base::Callback<bool(const GURL&)> predicate,
+ const DeletePageCallback& callback) {
+ DCHECK(is_loaded_);
+
+ std::vector<int64_t> offline_ids;
+ for (const auto& id_page_pair : offline_pages_) {
+ if (!id_page_pair.second.IsMarkedForDeletion() &&
+ predicate.Run(id_page_pair.second.url))
fgorski 2016/04/11 20:07:27 wrap with {} since the if statement spans more tha
dmurph 2016/04/11 22:29:29 Done.
+ offline_ids.push_back(id_page_pair.first);
+ }
+ DoDeletePagesByOfflineId(offline_ids, callback);
+}
+
bool OfflinePageModel::HasOfflinePages() const {
// Since offline pages feature is enabled by default,
// NetErrorTabHelper::SetHasOfflinePages might call this before the model is

Powered by Google App Engine
This is Rietveld 408576698