Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 1741123002: Add removal filter support for Cookies, Storage, and Content Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/browsing_data/browsing_data_remover.cc ('K') | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | chrome/browser/browsing_data/origin_filter_builder.h » ('j') | chrome/browser/content_settings/host_content_settings_map_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
index 4661b5574e89f351a29af6d9900a6a5746379734..4f9845fef4c2113fd6278c59ceb638b627b32525 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
@@ -1020,9 +1020,11 @@ class BrowsingDataRemoverTest : public testing::Test {
called_with_details_.reset(new BrowsingDataRemover::NotificationDetails());
+ OriginFilterBuilder builder(OriginFilterBuilder::BLACKLIST);
msramek 2016/02/29 17:46:07 The semantic of |remove_origin| is WHITELIST.
dmurph 2016/03/01 00:10:00 Done.
+ builder.AddOrigin(url::Origin(remove_origin));
BrowsingDataRemoverCompletionObserver completion_observer(remover);
remover->RemoveImpl(BrowsingDataRemover::Period(period), remove_mask,
- remove_origin, BrowsingDataHelper::UNPROTECTED_WEB);
+ builder, BrowsingDataHelper::UNPROTECTED_WEB);
completion_observer.BlockUntilCompletion();
// Save so we can verify later.
« chrome/browser/browsing_data/browsing_data_remover.cc ('K') | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | chrome/browser/browsing_data/origin_filter_builder.h » ('j') | chrome/browser/content_settings/host_content_settings_map_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698