Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 1741073002: Rename enums/functions that collide in chromium style in core/layout/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@get-names-6
Patch Set: get-names-7: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
index 353c95c0e17aba9471f917048d380269f5c3554c..e294061f630a284ea13a33f3db6fc4fca3bcfac6 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
@@ -765,7 +765,7 @@ LayoutUnit LayoutGrid::maxContentForChild(LayoutBox& child, GridTrackSizingDirec
return logicalHeightForChild(child, columnTracks);
}
-// We're basically using a class instead of a std::pair because of accessing gridItem() or gridSpan() is much more
+// We're basically using a class instead of a std::pair because of accessing gridItem() or getGridSpan() is much more
// self-explanatory that using .first or .second members in the pair. Having a std::pair<LayoutBox*, size_t>
// does not work either because we still need the GridSpan so we'd have to add an extra hash lookup for each item
// at the beginning of LayoutGrid::resolveContentBasedTrackSizingFunctionsForItems().
@@ -778,7 +778,7 @@ public:
}
LayoutBox& gridItem() const { return *m_gridItem; }
- GridSpan gridSpan() const { return m_gridSpan; }
+ GridSpan getGridSpan() const { return m_gridSpan; }
bool operator<(const GridItemWithSpan other) const { return m_gridSpan.integerSpan() < other.m_gridSpan.integerSpan(); }
@@ -991,8 +991,8 @@ void LayoutGrid::resolveContentBasedTrackSizingFunctionsForItems(GridTrackSizing
for (auto it = gridItemsWithSpan.rangeStart; it != gridItemsWithSpan.rangeEnd; ++it) {
GridItemWithSpan& gridItemWithSpan = *it;
- ASSERT(gridItemWithSpan.gridSpan().integerSpan() > 1);
- const GridSpan& itemSpan = gridItemWithSpan.gridSpan();
+ ASSERT(gridItemWithSpan.getGridSpan().integerSpan() > 1);
+ const GridSpan& itemSpan = gridItemWithSpan.getGridSpan();
sizingData.growBeyondGrowthLimitsTracks.shrink(0);
sizingData.filteredTracks.shrink(0);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutGeometryMap.h ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698