Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1741053002: Revert of Fix computation of runtime for throttled tasks (Closed)

Created:
4 years, 10 months ago by jaydasika
Modified:
4 years, 10 months ago
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix computation of runtime for throttled tasks (patchset #3 id:40001 of https://codereview.chromium.org/1718233002/ ) Reason for revert: Speculative revert for Compile failure on Win, Mac & Precise 64 Beta Bots (crbug.com/590286) Original issue's description: > Fix computation of runtime for throttled tasks > > The computation of the delayed task runtime was computing the (virtual) > TimeDomain's now + delay. That doesn't take into account the skew > between the real time and the virtual time, which meant timers could > run sooner than expected for background tabs. Timers associated with > foreground tabs are unaffected. > > This patch makes the computation of delayed runtime the responsibility > of the TimeDomain and introduces a ThrottledTimeDomain which computes > the delayed runtime as realtime + delay. > > This means timers will no longer run sooner than expected. Under normal > circumstancs this only timers whose delay modulo 1000ms is less than 100 > ms are less likely to be affected. Timers whose whose delay modulo > 1000ms is greater than 900 are highly likely to be affected (there's a > good chance their delay was too small before). > > BUG=587074 > > Committed: https://crrev.com/b56bbe4ce3e7276a130a00d83cf00e5672cd6be1 > Cr-Commit-Position: refs/heads/master@{#376993} TBR=skyostil@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=587074 Committed: https://crrev.com/7a1d629da81d8218afbf86eb4ff6c977970cd8d4 Cr-Commit-Position: refs/heads/master@{#377995}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -143 lines) Patch
M components/scheduler/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/base/real_time_domain.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/base/real_time_domain.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M components/scheduler/base/task_queue_impl.cc View 1 2 chunks +5 lines, -11 lines 0 comments Download
M components/scheduler/base/time_domain.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M components/scheduler/base/time_domain_unittest.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/scheduler/base/virtual_time_domain.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/base/virtual_time_domain.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
D components/scheduler/renderer/throttled_time_domain.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/scheduler/renderer/throttled_time_domain.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M components/scheduler/renderer/throttling_helper.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/scheduler/renderer/throttling_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/scheduler/renderer/throttling_helper_unittest.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download
M components/scheduler/scheduler.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jaydasika
Created Revert of Fix computation of runtime for throttled tasks
4 years, 10 months ago (2016-02-26 20:02:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741053002/1
4 years, 10 months ago (2016-02-26 20:12:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741053002/1
4 years, 10 months ago (2016-02-26 20:33:26 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/99515) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-26 20:35:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741053002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741053002/240001
4 years, 10 months ago (2016-02-26 21:00:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:240001)
4 years, 10 months ago (2016-02-26 22:07:45 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7a1d629da81d8218afbf86eb4ff6c977970cd8d4 Cr-Commit-Position: refs/heads/master@{#377995}
4 years, 10 months ago (2016-02-26 22:08:58 UTC) #10
jaydasika
4 years, 10 months ago (2016-02-26 23:34:41 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:240001) has been created in
https://codereview.chromium.org/1727273008/ by jaydasika@chromium.org.

The reason for reverting is: I reverted the wrong CL. Should have reverted the
cherry-picked CL. So, re-reverting this one..

Powered by Google App Engine
This is Rietveld 408576698