Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1741043003: A bit more privacy for SkiaServe's Request (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M tools/skiaserve/Request.h View 2 chunks +5 lines, -3 lines 0 comments Download
M tools/skiaserve/Request.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M tools/skiaserve/urlhandlers/BreakHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/urlhandlers/ClipAlphaHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/urlhandlers/DataHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/urlhandlers/DownloadHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/urlhandlers/ImgHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skiaserve/urlhandlers/PostHandler.cpp View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
joshualitt
This cl lets us hide the picture on the Request object.
4 years, 10 months ago (2016-02-26 20:44:00 UTC) #3
ethannicholas
lgtm
4 years, 10 months ago (2016-02-26 20:56:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1741043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1741043003/1
4 years, 9 months ago (2016-02-29 13:24:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 13:35:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6bc967984a59e2f6602b5661caa8353dc985a4cb

Powered by Google App Engine
This is Rietveld 408576698