Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1741003002: Cleanup forward declarations. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup forward declarations. This CL removes duplicate forward declarations, removes extraneous declarations and adds a couple of missing declarations. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/06f49c808a23d0ce9f89fd7fa6552a0f0ee96bbb

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -139 lines) Patch
M core/include/fpdfapi/fpdf_module.h View 1 chunk +0 lines, -8 lines 0 comments Download
M core/include/fpdfapi/fpdf_objects.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M core/include/fpdfapi/fpdf_page.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 1 chunk +0 lines, -5 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M core/include/fpdfapi/fpdf_serial.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +0 lines, -2 lines 0 comments Download
M core/include/fpdfdoc/fpdf_tagged.h View 1 chunk +0 lines, -2 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxge/fx_font.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdftext/text_int.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrrdProc.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafont.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_app.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_page.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fwl/adapter/fwl_adapterwidgetmgr.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_barcode.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_combobox.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_tooltipctrl.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_note.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/widgettp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fxfa/fxfa.h View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/include/fxfa/fxfa_widget.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/include/fxgraphics/fx_graphics.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fxjse/fxjse.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fdp/include/fde_brs.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fdp/include/fde_css.h View 2 chunks +0 lines, -11 lines 0 comments Download
M xfa/src/fdp/include/fde_rdr.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fdp/include/fde_rdv.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fdp/include/fde_xml.h View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_geobject.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fee/include/ifde_txtedtengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtengine.h View 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtpage.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fgas/include/fx_rbk.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_textbreak.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_datetimepickerimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_editimp.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_monthcalendarimp.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_scrollbarimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/include/fwl_noteimp.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_widgetimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/include/fwl_widgetmgrimp.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_Binarizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/BC_UtilRSS.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/common/BC_GlobalHistogramBinarizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode128Writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCode39Writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAWriter.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ECModulusGF.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ScanningDecoder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRAlignmentPattern.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRBitMatrixParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeReader.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeWriter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderEncoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetector.h View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetectorResult.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRGridSampler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffcheckbutton.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdocview.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fffield.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpushbutton.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftext.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/common/xfa_document.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/common/xfa_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_layout_imp.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL. Wrote a script to remove extraneous forward declarations.
4 years, 10 months ago (2016-02-26 16:21:08 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-26 20:12:57 UTC) #3
dsinclair
4 years, 9 months ago (2016-02-27 13:53:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
06f49c808a23d0ce9f89fd7fa6552a0f0ee96bbb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698