Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: content/renderer/media/rtc_certificate_generator.h

Issue 1740993002: RTCPeerConnection.generateCertificate: Optionally specify expiration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_certificate_generator.h
diff --git a/content/renderer/media/rtc_certificate_generator.h b/content/renderer/media/rtc_certificate_generator.h
index 95734fddf162dc342abaaa49444b6fb4b133737a..b582af9ea1a1d333b1596acfe07f1dfd486d94b8 100644
--- a/content/renderer/media/rtc_certificate_generator.h
+++ b/content/renderer/media/rtc_certificate_generator.h
@@ -9,6 +9,7 @@
#include "third_party/WebKit/public/platform/WebRTCCertificate.h"
#include "third_party/WebKit/public/platform/WebRTCCertificateGenerator.h"
#include "third_party/WebKit/public/platform/WebRTCKeyParams.h"
+#include "third_party/webrtc/base/optional.h"
namespace content {
@@ -26,9 +27,22 @@ class RTCCertificateGenerator : public blink::WebRTCCertificateGenerator {
const blink::WebURL& url,
const blink::WebURL& first_party_for_cookies,
std::unique_ptr<blink::WebRTCCertificateCallback> observer) override;
+ void generateCertificateWithExpiration(
+ const blink::WebRTCKeyParams& key_params,
+ const blink::WebURL& url,
+ const blink::WebURL& first_party_for_cookies,
+ uint64_t expires_ms,
+ std::unique_ptr<blink::WebRTCCertificateCallback> observer) override;
bool isSupportedKeyParams(const blink::WebRTCKeyParams& key_params) override;
private:
+ void generateCertificateWithOptionalExpiration(
+ const blink::WebRTCKeyParams& key_params,
+ const blink::WebURL& url,
+ const blink::WebURL& first_party_for_cookies,
+ const rtc::Optional<uint64_t>& expires_ms,
+ std::unique_ptr<blink::WebRTCCertificateCallback> observer);
+
DISALLOW_COPY_AND_ASSIGN(RTCCertificateGenerator);
};

Powered by Google App Engine
This is Rietveld 408576698