third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html - Issue 1740923004: IntersectionObserver: make exceptions match spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html

Issue 1740923004: IntersectionObserver: make exceptions match spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: ASSERT observer constructor succeeded if no exception was thrown Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html b/third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html

index 606d02edb04325ed3e7d55b229f98bed939624d0..7bc010d2a7407a7e1cbb3abc46cfe65ecf3dc9ab 100644

--- a/third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html

+++ b/third_party/WebKit/LayoutTests/http/tests/intersection-observer/resources/cross-origin-subframe.html

@@ -18,7 +18,9 @@ function observer_callback(changes) {

for (var i in changes)

entries.push(changes[i]);

}

-var observer = new IntersectionObserver(observer_callback, {});

+// Use a rootMargin here, and verify it does NOT get applied for the cross-origin case.

+var observer = new IntersectionObserver(observer_callback, {rootMargin: "7px"});

observer.observe(target);

function step0() {

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/observer-exceptions.html » ('j') | no next file with comments »