Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.h

Issue 1740923004: IntersectionObserver: make exceptions match spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Get rid of IntersectionObserver::hasRootMargin Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/IntersectionObserver.h
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.h b/third_party/WebKit/Source/core/dom/IntersectionObserver.h
index 12b82835d8efc1c557b4e9085d9290a859000383..c027b3cff9c7422bdc70fc7fe8389f6b475d7b96 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.h
+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.h
@@ -29,8 +29,9 @@ public:
static void resumeSuspendedObservers();
// API methods
- void observe(Element*, ExceptionState&);
- void unobserve(Element*, ExceptionState&);
+ void observe(Element*);
+ void unobserve(Element*);
+ void disconnect();
HeapVector<Member<IntersectionObserverEntry>> takeRecords();
Element* root() const;
String rootMargin() const;
@@ -38,7 +39,6 @@ public:
Node* rootNode() const { return m_root.get(); }
LayoutObject* rootLayoutObject() const;
- bool hasPercentMargin() const;
const Length& topMargin() const { return m_topMargin; }
const Length& rightMargin() const { return m_rightMargin; }
const Length& bottomMargin() const { return m_bottomMargin; }
@@ -48,7 +48,6 @@ public:
void applyRootMargin(LayoutRect&) const;
unsigned firstThresholdGreaterThan(float ratio) const;
void deliver();
- void disconnect();
void removeObservation(IntersectionObservation&);
bool hasEntries() const { return m_entries.size(); }
const HeapHashSet<WeakMember<IntersectionObservation>>& observations() const { return m_observations; }

Powered by Google App Engine
This is Rietveld 408576698