third_party/WebKit/Source/core/dom/IntersectionObservation.h - Issue 1740923004: IntersectionObserver: make exceptions match spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.h

Issue 1740923004: IntersectionObserver: make exceptions match spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Get rid of IntersectionObserver::hasRootMargin Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObservation.h

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.h b/third_party/WebKit/Source/core/dom/IntersectionObservation.h

index 5df531f4b85acc1b80e1adb222bdca06df8f8d1f..9a3413a6c98d35711a7a4779bf59e13bc6f578ea 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.h

+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.h

@@ -38,10 +38,11 @@ public:

DECLARE_TRACE();

private:

- void initializeGeometry(IntersectionGeometry&);

- void clipToRoot(LayoutRect&);

- void clipToFrameView(IntersectionGeometry&);

- bool computeGeometry(IntersectionGeometry&);

+ void applyRootMargin(LayoutRect&) const;

+ void initializeGeometry(IntersectionGeometry&) const;

+ void clipToRoot(LayoutRect&) const;

+ void clipToFrameView(IntersectionGeometry&) const;

+ bool computeGeometry(IntersectionGeometry&) const;

Member<IntersectionObserver> m_observer;