third_party/WebKit/Source/core/dom/IntersectionObserver.h - Issue 1740923004: IntersectionObserver: make exceptions match spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.h

Issue 1740923004: IntersectionObserver: make exceptions match spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Call disconnect from clearWeakMembers Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObserver.h

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.h b/third_party/WebKit/Source/core/dom/IntersectionObserver.h

index 12b82835d8efc1c557b4e9085d9290a859000383..6f592fce488f37b2488dff2faeb9297be4640b87 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.h

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.h

@@ -30,7 +30,8 @@ public:

// API methods

void observe(Element*, ExceptionState&);

- void unobserve(Element*, ExceptionState&);

+ void unobserve(Element*);

+ void disconnect();

HeapVector<Member<IntersectionObserverEntry>> takeRecords();

Element* root() const;

String rootMargin() const;

@@ -48,7 +49,6 @@ public:

void applyRootMargin(LayoutRect&) const;

unsigned firstThresholdGreaterThan(float ratio) const;

void deliver();

- void disconnect();

void removeObservation(IntersectionObservation&);

bool hasEntries() const { return m_entries.size(); }

const HeapHashSet<WeakMember<IntersectionObservation>>& observations() const { return m_observations; }