Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Side by Side Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.h

Issue 1740923004: IntersectionObserver: make exceptions match spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: ASSERT observer constructor succeeded if no exception was thrown Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IntersectionObservation_h 5 #ifndef IntersectionObservation_h
6 #define IntersectionObservation_h 6 #define IntersectionObservation_h
7 7
8 #include "core/dom/DOMHighResTimeStamp.h" 8 #include "core/dom/DOMHighResTimeStamp.h"
9 #include "platform/geometry/LayoutRect.h" 9 #include "platform/geometry/LayoutRect.h"
10 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
(...skipping 20 matching lines...) Expand all
31 unsigned lastThresholdIndex() const { return m_lastThresholdIndex; } 31 unsigned lastThresholdIndex() const { return m_lastThresholdIndex; }
32 void setLastThresholdIndex(unsigned index) { m_lastThresholdIndex = index; } 32 void setLastThresholdIndex(unsigned index) { m_lastThresholdIndex = index; }
33 bool shouldReportRootBounds() const { return m_shouldReportRootBounds; } 33 bool shouldReportRootBounds() const { return m_shouldReportRootBounds; }
34 void computeIntersectionObservations(DOMHighResTimeStamp); 34 void computeIntersectionObservations(DOMHighResTimeStamp);
35 void disconnect(); 35 void disconnect();
36 void clearRootAndRemoveFromTarget(); 36 void clearRootAndRemoveFromTarget();
37 37
38 DECLARE_TRACE(); 38 DECLARE_TRACE();
39 39
40 private: 40 private:
41 void initializeGeometry(IntersectionGeometry&); 41 void applyRootMargin(LayoutRect&) const;
42 void clipToRoot(LayoutRect&); 42 void initializeGeometry(IntersectionGeometry&) const;
43 void clipToFrameView(IntersectionGeometry&); 43 void clipToRoot(LayoutRect&) const;
44 bool computeGeometry(IntersectionGeometry&); 44 void clipToFrameView(IntersectionGeometry&) const;
45 bool computeGeometry(IntersectionGeometry&) const;
45 46
46 Member<IntersectionObserver> m_observer; 47 Member<IntersectionObserver> m_observer;
47 48
48 // TODO(szager): Why Node instead of Element? Because NodeIntersectionObser verData::createWeakPtr() 49 // TODO(szager): Why Node instead of Element? Because NodeIntersectionObser verData::createWeakPtr()
49 // returns a WeakPtr<Node>, which cannot be coerced into a WeakPtr<Element>. When oilpan rolls out, 50 // returns a WeakPtr<Node>, which cannot be coerced into a WeakPtr<Element>. When oilpan rolls out,
50 // this can be changed to WeakMember<Element>. 51 // this can be changed to WeakMember<Element>.
51 WeakPtrWillBeWeakMember<Node> m_target; 52 WeakPtrWillBeWeakMember<Node> m_target;
52 53
53 unsigned m_shouldReportRootBounds : 1; 54 unsigned m_shouldReportRootBounds : 1;
54 unsigned m_lastThresholdIndex : 30; 55 unsigned m_lastThresholdIndex : 30;
55 }; 56 };
56 57
57 } // namespace blink 58 } // namespace blink
58 59
59 #endif // IntersectionObservation_h 60 #endif // IntersectionObservation_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698