IntersectionObserver: make exceptions match spec

IntersectionObserver: fix exceptions and handling of cross-origin root margin

BUG=540528
Committed: https://crrev.com/d151332e6b19119aff8ab7ef05b602ead73fb090
Cr-Commit-Position: refs/heads/master@{#378387}

[szager1, 2016-02-27 00:06:45]

Description was changed from

==========
IntersectionObserver: make exceptions match spec

BUG=540528
==========

to

==========
IntersectionObserver: make exceptions match spec

BUG=540528
==========

[szager1, 2016-02-27 00:06:45]

szager@chromium.org changed reviewers:
+ esprehn@chromium.org, ojan@chromium.org

[ojan, 2016-02-27 01:45:45]

https://codereview.chromium.org/1740923004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserver.cpp (right):

https://codereview.chromium.org/1740923004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserver.cpp:178:
exceptionState.throwDOMException(InvalidStateError, "Invalid observer: root
element or containing document has been deleted.");
I thought we decided this case wouldn't throw?

[szager1, 2016-02-29 22:34:38]

Description was changed from

==========
IntersectionObserver: make exceptions match spec

BUG=540528
==========

to

==========
IntersectionObserver: fix exceptions and handling of cross-origin root margin

BUG=540528
==========

[szager1, 2016-02-29 22:35:53]

https://codereview.chromium.org/1740923004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserver.cpp (right):

https://codereview.chromium.org/1740923004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserver.cpp:178:
exceptionState.throwDOMException(InvalidStateError, "Invalid observer: root
element or containing document has been deleted.");
On 2016/02/27 01:45:45, ojan wrote:
> I thought we decided this case wouldn't throw?

Initially, I had thought this method would still throw for the other error
cases.  On further consideration, that's not right; in particular, a
cross-origin observe() on an observer with a root margin should not throw, it
should just not use the margin when computing intersections.

I added the above change and a test.

[ojan, 2016-02-29 23:32:02]

The CQ bit was checked by ojan@chromium.org

[ojan, 2016-02-29 23:32:03]

lgtm

[commit-bot: I haz the power, 2016-02-29 23:33:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740923004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740923004/60001

[haraken, 2016-02-29 23:35:56]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-02-29 23:35:56]

bindings LGTM

https://codereview.chromium.org/1740923004/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp
(right):

https://codereview.chromium.org/1740923004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp:46:
if (!observer) {

Can this be ASSERT(observer)? If observer is null, an exception should have been
thrown at line 44.

[ojan, 2016-02-29 23:36:43]

The CQ bit was unchecked by ojan@chromium.org

[szager1, 2016-02-29 23:45:39]

https://codereview.chromium.org/1740923004/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp
(right):

https://codereview.chromium.org/1740923004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8IntersectionObserverCustom.cpp:46:
if (!observer) {
On 2016/02/29 23:35:56, haraken wrote:
> 
> Can this be ASSERT(observer)? If observer is null, an exception should have
been
> thrown at line 44.

Done.

[ojan, 2016-03-01 00:56:16]

The CQ bit was checked by ojan@chromium.org

[ojan, 2016-03-01 00:56:16]

lgtm

[ojan, 2016-03-01 00:56:16]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1740923004/#ps80001
(title: "ASSERT observer constructor succeeded if no exception was thrown")

[commit-bot: I haz the power, 2016-03-01 00:56:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740923004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740923004/80001

[commit-bot: I haz the power, 2016-03-01 01:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 01:53:42]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[szager1, 2016-03-01 01:56:40]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2016-03-01 01:57:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1740923004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1740923004/80001

[commit-bot: I haz the power, 2016-03-01 03:26:33]

Description was changed from

==========
IntersectionObserver: fix exceptions and handling of cross-origin root margin

BUG=540528
==========

to

==========
IntersectionObserver: fix exceptions and handling of cross-origin root margin

BUG=540528
==========

[commit-bot: I haz the power, 2016-03-01 03:26:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-01 03:28:01]

Description was changed from

==========
IntersectionObserver: fix exceptions and handling of cross-origin root margin

BUG=540528
==========

to

==========
IntersectionObserver: fix exceptions and handling of cross-origin root margin

BUG=540528

Committed: https://crrev.com/d151332e6b19119aff8ab7ef05b602ead73fb090
Cr-Commit-Position: refs/heads/master@{#378387}
==========

[commit-bot: I haz the power, 2016-03-01 03:28:03]

Patchset 5 (id:??) landed as
https://crrev.com/d151332e6b19119aff8ab7ef05b602ead73fb090
Cr-Commit-Position: refs/heads/master@{#378387}