Replace CPDF_Rect and CPDF_Point with CFX types.

Replace CPDF_Rect and CPDF_Point with CFX types.

Too many rectangle types.  Remove CPDF_Rect #define, and
make an equivalent point type in CFX, but stop short of
consolidating the N different forms of rectangles in CFX.

Also banish PDF_ClipFloat to the one .cpp file that needs it,
since it was in the vicinity of the .h file changes.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3b8fdd34bdf57ec45291b77008a43249f838efcb

[Tom Sepez, 2016-02-26 17:56:34]

Description was changed from

==========
Replace CPDF_Rect and CPDF_Point with CFX types.

Too many rectangle types.  Remove CPDF_Rect #define, and
make an equivalent point type in CFX, but stop short of
consolidating the N different forms of rectangles in CFX.
==========

to

==========
Replace CPDF_Rect and CPDF_Point with CFX types.

Too many rectangle types.  Remove CPDF_Rect #define, and
make an equivalent point type in CFX, but stop short of
consolidating the N different forms of rectangles in CFX.

Also banish PDF_ClipFloat to the one .cpp file that needs it,
since it was in the vicinity of the .h file changes.
==========

[Tom Sepez, 2016-02-26 17:56:34]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-26 17:56:58]

On 2016/02/26 17:56:34, Tom Sepez wrote:
> mailto:tsepez@chromium.org changed reviewers:
> + mailto:thestig@chromium.org

Lei, for review.  Mostly mechanical change.

[Tom Sepez, 2016-02-26 18:04:17]

Non-mechanical changes:

https://codereview.chromium.org/1740923003/diff/1/core/include/fpdfapi/fpdf_p...
File core/include/fpdfapi/fpdf_parser.h (left):

https://codereview.chromium.org/1740923003/diff/1/core/include/fpdfapi/fpdf_p...
core/include/fpdfapi/fpdf_parser.h:682: class CPDF_Point {
Move this to fx_coordinates as CFX_FloatPoint.

https://codereview.chromium.org/1740923003/diff/1/core/include/fpdfapi/fpdf_p...
core/include/fpdfapi/fpdf_parser.h:705: FX_FLOAT PDF_ClipFloat(FX_FLOAT f);
Move this to one CPP file that needs it.

https://codereview.chromium.org/1740923003/diff/1/core/include/fxcrt/fx_coord...
File core/include/fxcrt/fx_coordinates.h (right):

https://codereview.chromium.org/1740923003/diff/1/core/include/fxcrt/fx_coord...
core/include/fxcrt/fx_coordinates.h:419: class CFX_FloatPoint {
From before.

https://codereview.chromium.org/1740923003/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp (right):

https://codereview.chromium.org/1740923003/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp:19: 
from before.

[Lei Zhang, 2016-02-26 20:11:22]

lgtm

[Tom Sepez, 2016-02-26 21:09:46]

Description was changed from

==========
Replace CPDF_Rect and CPDF_Point with CFX types.

Too many rectangle types.  Remove CPDF_Rect #define, and
make an equivalent point type in CFX, but stop short of
consolidating the N different forms of rectangles in CFX.

Also banish PDF_ClipFloat to the one .cpp file that needs it,
since it was in the vicinity of the .h file changes.
==========

to

==========
Replace CPDF_Rect and CPDF_Point with CFX types.

Too many rectangle types.  Remove CPDF_Rect #define, and
make an equivalent point type in CFX, but stop short of
consolidating the N different forms of rectangles in CFX.

Also banish PDF_ClipFloat to the one .cpp file that needs it,
since it was in the vicinity of the .h file changes.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/3b8fdd34bdf57ec45291b77008a43249f838...
==========

[Tom Sepez, 2016-02-26 21:09:49]

Committed patchset #1 (id:1) manually as
3b8fdd34bdf57ec45291b77008a43249f838efcb (presubmit successful).

[Tom Sepez, 2016-02-26 21:22:36]

https://codereview.chromium.org/1740923003/diff/1/core/include/fxcrt/fx_coord...
File core/include/fxcrt/fx_coordinates.h (right):

https://codereview.chromium.org/1740923003/diff/1/core/include/fxcrt/fx_coord...
core/include/fxcrt/fx_coordinates.h:421: CFX_FloatPoint(FX_FLOAT xx, FX_FLOAT
yy) : x(xx), y(xx) {}
Tommy can't type.